[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] Replace Long.js with native BigInt #248

Open
acrisci opened this issue Nov 8, 2018 · 2 comments
Open

[proposal] Replace Long.js with native BigInt #248

acrisci opened this issue Nov 8, 2018 · 2 comments

Comments

@acrisci
Copy link
acrisci commented Nov 8, 2018 •
edited
Loading

BigInt is a native way to represent 64 bit integers (dbus type x) in node.

Available since version 10.8.0.

https://node.green/#ESNEXT-candidate--stage-3--BigInt

https://developers.google.com/web/updates/2018/05/bigint

Do you see any issues with that?
@acrisci acrisci changed the title Replace Long.js with native BigInt [proposal] Replace Long.js with native BigInt Nov 8, 2018
@sidorares
Copy link
Owner

I was thinking about it, but might be a bit too early?
Maybe OK to go with migger api changes ( async/await etc ) in major version.

@CyDragon80 CyDragon80 mentioned this issue Nov 21, 2018
Open
@CyDragon80
Copy link
CyDragon80 commented Nov 21, 2018 •
edited
Loading

I created a PR #252 with a potential interim solution to at least present the option of marshalling/unmarshalling BigInts when the feature is available. Over time it would probably make sense to shift towards the native type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sidorares @CyDragon80 @acrisci