8000 Comparing yugabyte:master...shubin-yb:master · yugabyte/charts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: yugabyte/charts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: shubin-yb/charts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 1 commit
  • 9 files changed
  • 1 contributor

Commits on May 25, 2023

  1. [PLAT-8544] Merge affinity rules correctly

    Summary:
    Affinity rules were not merging correctly, allowing customers to fully
    overwrite nodeAffinity when they meant to add to it.
    
    We now merge on both nodeAffinity and podAntiAffinity correctly. If
    a user desires, they are still able to overwrite fields within those, but
    it is not possible to add more affinity rules without overwriting the
    existing rules
    
    Test Plan:
    tested with tserver and master custom affinities of podAntiAffinity and
    nodeAffinity, and validated they merged correctly.
    helm template .
    
    Re-ran the same test with
    helm template . --set AZ=test
    
    to validate the workflow with and without az set
    
    Reviewers: bgandhi, sanketh, sneelakantan, anijhawan
    
    Reviewed By: bgandhi, anijhawan
    
    Subscribers: jenkins-bot, anijhawan
    
    Differential Revision: https://phorge.dev.yugabyte.com/D25142
    shubin-yb committed May 25, 2023
    Configuration menu
    Copy the full SHA
    b7b7786 View commit details
    Browse the repository at this point in the history
Loading
0