8000 `./mach clippy -p` ignores `--features` · Issue #35428 · servo/servo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./mach clippy -p ignores --features #35428

Open
Loirooriol opened this issue Feb 11, 2025 · 1 comment
Open

./mach clippy -p ignores --features #35428

Loirooriol opened this issue Feb 11, 2025 · 1 comment
Labels
A-mach python Pull requests that update Python code

Comments

@Loirooriol
Copy link
Contributor

For example, ./mach clippy -r -p script --features webgpu invokes cargo clippy without --features webgpu.

For some reason, features are only used when you don't specify -p:

servo/python/servo/command_base.py

Lines 817 to 831 in cf3ad2d

if "-p" not in cargo_args: # We're building specific package, that may not have features
features += list(self.features)
if self.enable_media:
features.append("media-gstreamer")
if self.config["build"]["debug-mozjs"] or debug_mozjs:
features.append("debugmozjs")
if with_frame_pointer:
env['RUSTFLAGS'] = env.get('RUSTFLAGS', "") + " -C force-frame-pointers=yes"
features.append("profilemozjs")
if self.config["build"]["webgl-backtrace"]:
features.append("webgl-backtrace")
if self.config["build"]["dom-backtrace"]:
features.append("js_backtrace")
args += ["--features", " ".join(features)]

That seems quite unexpected?
@Loirooriol Loirooriol added A-mach python Pull requests that update Python code labels Feb 11, 2025
@Loirooriol
Copy link
Contributor Author

This comes from #29808. @mrobinson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mach python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Loirooriol
0