Comparing changes
Open a pull request
- 11 commits
- 6 files changed
- 4 contributors
Commits on Jul 1, 2024
-
-
Merge pull request #1152 from cforycki/fix/index-map-minimal-version
fix: indexmap minimal version with Map::shift_insert()
-
Commits on Jul 2, 2024
-
Correct documentation URL for Value's Index impl.
The current id doesn't exist, so the link just goes to the top of the docs for Value, rather than to the intended section covering `impl<I> Index<I> for Value`.
Commits on Jul 3, 2024
-
Merge pull request #1153 from dpathakj/master
Correct documentation URL for Value's Index impl.
Commits on Jul 12, 2024
-
Ignore byte_char_slices clippy lint in test
warning: can be more succinctly written as a byte str --> tests/test.rs:1108:13 | 1108 | &[b'"', b'\n', b'"'], | ^^^^^^^^^^^^^^^^^^^^ help: try: `b"\"\n\""` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices = note: `-W clippy::byte-char-slices` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::byte_char_slices)]` warning: can be more succinctly written as a byte str --> tests/test.rs:1112:13 | 1112 | &[b'"', b'\x1F', b'"'], | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `b"\"\x1F\""` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices
Commits on Jul 26, 2024
-
-
Merge pull request #1159 from iex-rs/fix-recursion
Move call to tri! out of check_recursion!
-
Optimize position search in error path
Translating index into a line/column pair takes considerable time. Notably, the JSON benchmark modified to run on malformed data spends around 50% of the CPU time generating the error object. While it is generally assumed that the cold path is quite slow, such a drastic pessimization may be unexpected, especially when a faster implementation exists. Using vectorized routines provided by the memchr crate increases performance of the failure path by 2x on average. Old implementation: DOM STRUCT data/canada.json 122 MB/s 168 MB/s data/citm_catalog.json 135 MB/s 195 MB/s data/twitter.json 142 MB/s 226 MB/s New implementation: DOM STRUCT data/canada.json 216 MB/s 376 MB/s data/citm_catalog.json 238 MB/s 736 MB/s data/twitter.json 210 MB/s 492 MB/s In comparison, the performance of the happy path is: DOM STRUCT data/canada.json 283 MB/s 416 MB/s data/citm_catalog.json 429 MB/s 864 MB/s data/twitter.json 275 MB/s 541 MB/s While this introduces a new dependency, memchr is much faster to compile than serde, so compile time does not increase significantly. Additionally, memchr provides a more efficient SWAR-based implementation of both the memchr and count routines even without std, providing benefits for embedded uses as well.
Commits on Jul 28, 2024
-
Merge pull request #1160 from iex-rs/efficient-position
Optimize position search in error path
-
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.119...v1.0.121