8000 Add invalid state to keyboard commands and show localized `Not in Wikidata` · Issue #273 · scribe-org/Scribe-Android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add invalid state to keyboard commands and show localized Not in Wikidata #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
andrewtavis opened this issue Dec 15, 2024 · 9 comments
Open
2 tasks done

Add invalid state to keyboard commands and show localized Not in Wikidata #273

andrewtavis opened this issue Dec 15, 2024 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member
andrewtavis commented Dec 15, 2024 •
edited
Loading

Terms

Description

This issue would add the invalid input functionality to Scribe-Android keyboards. In Scribe-iOS, when a user tries to execute a command on a word that's not a valid value in the given database, the localized version of the string Not in Wikidata is displayed to the user on the command bar.

A screenshot of this in Scribe-iOS is seen below:

Simulator Screenshot - iPhone 16 Pro - 2024-12-15 at 19 26 25

The functionality is:

Note

The invalid state messages can be found in the interface files in the language directories of app/src/main/java/be/scri/helpers.

Contribution

Happy to discuss this and review when a PR is open! 🚀
@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed blocked Another issue is blocking labels Dec 15, 2024
@andrewtavis andrewtavis mentioned this issue Dec 15, 2024
Open
2 tasks
@andrewtavis andrewtavis mentioned this issue Jan 29, 2025
Closed
2 tasks
@smalik2811
Copy link
Contributor

@andrewtavis I would like to take this one. Also if possible, could you share the video of how it works in the iOS, that would make the things more clear 🙂

@andrewtavis
Copy link
Member Author

Thanks for your willingness to work on this, @smalik2811! Here's a video for how it works in iOS, as requested 😊

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-05.at.19.44.16.mp4

Please let us know if there are further questions!

@smalik2811
Copy link
Contributor

Thankyou for the video. Also I would like to clarify what happens when the user clicks the Scribe key in the Invalid state? Does it switch back to the Idle mode?
8000

@andrewtavis
Copy link
Member Author

In file state the Scribe key will result in the command options being shown :) So when the "Not in Wikidata" message is shown, then the user can press the Scribe key to see the commands and maybe retry the one that didn't work.

@smalik2811
Copy link
Contributor

Hello @andrewtavis, I have been working on the Invalid State and I have managed to get the current functionality by hiding the views from the command bar. However that's not enough I would also have to update the background drawable of the scribe key and restore it when the the keyboard exits the invalid state which makes the logic little complicated and does not follow SOLID principles.

I was wondering if we could create a seperate layout file for the Invalid state that would make the logic more clean and easy to maintain. What do you recommend?

Additionally, could you also share the colors that should be used for the info icon in the invalid state for both the light and dark mode.

Invalid.State.webm

@andrewtavis
Copy link
Member Author

Thanks for the great work here as always, @smalik2811!

I was wondering if we could create a seperate layout file for the Invalid state that would make the logic more clean and easy to maintain. What do you recommend?

I think a separate layout file for the invalid state would be great :) Feel free to go in that direction! 🚀

Additionally, could you also share the colors that should be used for the info icon in the invalid state for both the light and dark mode.

The color we use for this is the same as the placeholder text for the command bar - commandBarPlaceholderColor in iOS:

  • Light mode: #8A8A92
  • Dark mode: #777777

Let me know if there's anything else I can do to help!

@andrewtavis andrewtavis removed the feature New feature or request label Feb 26, 2025
@andrewtavis
Copy link
Member Author

Hey @smalik2811 👋 Quick check in here to see if there's anything we can do to support on this issue :) Hope all's well with you! 😊

@smalik2811
Copy link
Contributor

Hi @andrewtavis ,

Thank you for checking in! I appreciate you reaching out. I've been engaged with some other tasks recently, and unfortunately, I won't be able to contribute to this particular issue at this time. Therefore, I'd like to remove myself from this issue.

I'm still very interested in contributing to the project in the future, and I'll keep an eye out for other opportunities.

Thanks again for your understanding.

@andrewtavis
Copy link
Member Author

Totally fine, @smalik2811! We hope to see you in the future :)

@andrewtavis andrewtavis removed the blocked Another issue is blocking label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
Scribe Board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtavis @smalik2811
0