[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backport): Access jax.config from jax #2423

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix(backport): Access jax.config from jax #2423

merged 1 commit into from
Jan 5, 2024

Conversation

matthewfeickert
Copy link
Member
@matthewfeickert matthewfeickert commented Jan 5, 2024 •
edited
Loading

Description

Backport PR #2376

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR https://github.com/scikit-hep/pyhf/pull/2376
* As of jax and jaxlib v0.4.20 accessing jax.config from the jax.config
  submodule is deprecated and it should be accessed from the jax top
  level API instead.

   ```
   >>> from jax.config import config
   <stdin>:1: DeprecationWarning: Accessing jax.config via the jax.config submodule is deprecated
   ```

@matthewfeickert
fix(backport): Access jax.config from jax
f00af9a 
* As of jax and jaxlib v0.4.20 accessing jax.config from the jax.config
  submodule is deprecated and it should be accessed from the jax top
  level API instead.

   ```
   >>> from jax.config import config
   <stdin>:1: DeprecationWarning: Accessing jax.config via the jax.config submodule is deprecated
   ```
@matthewfeickert matthewfeickert added fix A bug fix backport Backport PRs from main to release branch labels Jan 5, 2024
@matthewfeickert matthewfeickert self-assigned this Jan 5, 2024
@codecov Codecov
Copy link
codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v0.7.x@51e55f7). Click here to learn what that means.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/v0.7.x    #2423   +/-   ##
=================================================
  Coverage                  ?   98.21%           
=================================================
  Files                     ?       69           
  Lines                     ?     4543           
  Branches                  ?      803           
=================================================
  Hits                      ?     4462           
  Misses                    ?       47           
  Partials                  ?       34
Flag Coverage Δ
contrib 27.53% <0.00%> (?)
doctest 60.99% <0.00%> (?)
unittests-3.10 96.25% <0.00%> (?)
unittests-3.11 96.25% <0.00%> (?)
unittests-3.7 96.23% <0.00%> (?)
unittests-3.8 96.27% <0.00%> (?)
unittests-3.9 96.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 9c9fc87 into release/v0.7.x Jan 5, 2024
21 checks passed
@matthewfeickert matthewfeickert deleted the backport/jax-config-fix branch January 5, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
backport Backport PRs from main to release branch fix A bug fix
Projects
pyhf v0.7.6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert