[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: we should be able to combine years, lumis, and coms together #456

Closed
ikrommyd opened this issue Oct 16, 2023 · 4 comments
Closed

feat: we should be able to combine years, lumis, and coms together #456

ikrommyd opened this issue Oct 16, 2023 · 4 comments

Comments

@ikrommyd
Copy link
ikrommyd commented Oct 16, 2023

Very often in plots, we combine different data taking periods together. Therefore we should be able to specify lists of lumis, years and coms of the same length together and mplhep should create a label like the following image:
image

If that's already there and I'm not seeing it I'm sorry.

@ikrommyd ikrommyd changed the title we should be able to combine years, lumis, and coms together feat: we should be able to combine years, lumis, and coms together Oct 16, 2023
@andrzejnovak
Copy link
Member

This already exists in the form of rlabel= which forces whatever text you want on the right side. The label you posted is imo too specific to generate it programmatically from some lists.

@ikrommyd
Copy link
Author

Ah so you're saying the solution is to type out the right lumi, com, year combination in plain text using rlabel. I was thinking of something like an input to cms.label where you'd say lumi=(58.7, 34.3), com=(13, 13.6), year=(2018, 2022) and it would just generate this. I thought I'd open an issue for discussion just because I see this type of label frequently (it was also in the higgs discovery plots).

@andrzejnovak
Copy link
Member
andrzejnovak commented Oct 16, 2023

I don't personally think this is particularly simpler for the user in the sense that what if they prefer to write eg 92fb (13; 13,6 TeV) 2018-2022 instead. Feel free to correct me if we have a definite guidance on how this should be structured (at least in CMS). That said, since your proposal doesn't really change the API and the logic should be pretty straightforward for future maintenance, I am ok to merge it if you want to submit a PR.

Side note since this label would likely be too long to have the CMS label also on top, ideally this could come with new functionality that checks for overlap and emits a warning for the user to use the in-frame CMS label position.

@ikrommyd
Copy link
Author

Yeah you can use this 92fb (13; 13,6 TeV) 2018-2022 if it is somewhat a continuous data taking period. I think the format I typed is the standard according to guidelines (at least in CMS) when we refer to different discreet years. I just got this idea because I'm currently preparing the DPS note presentation for E/Gamma and I wanted to use this format. I'm very busy these days but I will read more to see if there is some generic guideline (also for other experiments) and create a simple PR to do this. You can close this issue if you want in the meantime if you don't want issue cluttering.

@ikrommyd ikrommyd closed this as completed Apr 2, 2024
@ikrommyd ikrommyd closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants