8000 Fallback function could be made payable. · Issue #712 · safe-global/safe-smart-account · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fallback function could be made payable. #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MicahZoltu opened this issue Dec 9, 2023 · 1 comment
Open

Fallback function could be made payable. #712

MicahZoltu opened this issue Dec 9, 2023 · 1 comment
Labels
future Features for next major contract version

Comments

@MicahZoltu
Copy link
Contributor

https://github.com/safe-global/safe-contracts/blob/bf943f80fec5ac647159d26161446ac5d716a294/contracts/base/FallbackManager.sol#L61

One can use the FallbackManager to add functions to the safe, but since the fallback method it defines is not payable, one cannot use it to add any new payable functions. There is already a native receive handler, so value with empty data is allowed, but not a novel function with value attached.

Adding payable to the fallback function should fix this.
@nlordell nlordell added the future Features for next major contract version label Oct 31, 2024
@rmeissner
Copy link
Member

Currently there is no way of passing the value amount to the fallback handler. This means that we would have to change (in a potentially compatibility breaking way) the interface between Safe and fallback handler, therefore this will only be considered for a future major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future Features for next major contract version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MicahZoltu @rmeissner @nlordell
0