Using the three dots format to add items to an array gives an error #2718

fabioflx · 2025-05-07T10:58:53Z

Since v3.21.x, clearing the cache of a Symfony project fails if twig files use the "three dots" format to add circumstantial elements to an array.
The following code works on v3.20.x instead:

{% set condition = true %}
{% include 'component.json.twig' with {
  items: [
    include('something1.json.twig', {}),
    ...condition ? [include('something2.json.twig', {})] : []
  ]
%}

The text was updated successfully, but these errors were encountered:

smnandre · 2025-05-07T11:48:03Z

Did you try with parenthesis here ?

    ...(condition ? [include('something2.json.twig', {})] : [])

Also i'm a bit surprised include('something2.json.twig', {}) is used here as a way to get values ... 🤔

fabioflx · 2025-05-07T12:16:10Z

Did you try with parenthesis here ?
...(condition ? [include('something2.json.twig', {})] : [])
Also i'm a bit surprised include('something2.json.twig', {}) is used here as a way to get values ... 🤔

Thank you, but I tried with parenthesis and it gives the same error.
Please don't mind the include part as it's just an example; the error is in the "..." part even when you use something much easier like ...true ? [] : []

smnandre · 2025-05-07T21:46:02Z

Could you show the exact code in question, for us to try to help ?

Kocal · 2025-05-08T09:57:57Z

What is the error?

fabioflx · 2025-05-08T14:37:04Z

Ok, this real code does not work:

{% set something = [
    ...true ? ['a'] : ['b']
  ]
%}

The error line reads:
14:35:28 CRITICAL [php] Uncaught Error: syntax error, unexpected token "..." ["exception" => ParseError { …}]

Kocal · 2025-05-09T01:49:11Z

Then it's more an issue from Twig? What version of Twig do you use ?

fabioflx · 2025-05-09T06:48:44Z

Then it's more an issue from Twig? What version of Twig do you use ?

The error is on v3.21.x but the code works on v3.20.x.
I notified the issue on Twig project too, thank you

smnandre · 2025-05-10T16:41:43Z

Just tested, this exact code works on 3.21

    {% set something = [
        ...(true ? ['a'] : ['b'])
      ]
    %}

    {{ something|json_encode }}

Without parenthesis, it does produce the following error

syntax error, unexpected token "..."

smnandre · 2025-05-10T16:46:40Z

Deciding if it's a bug will not something we can do here. So i'm closing here and let you continue the discussion on the twig topic indeed.

fabioflx added the Bug Bug Fix label May 7, 2025

carsonbot added the Status: Needs Review Needs to be reviewed label May 7, 2025

smnandre closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using the three dots format to add items to an array gives an error #2718

Using the three dots format to add items to an array gives an error #2718

Using the three dots format to add items to an array gives an error #2718

Using the three dots format to add items to an array gives an error #2718

Comments