From b9c899a5eabf7e618921d1acd7f26222685b7841 Mon Sep 17 00:00:00 2001 From: bohan Date: Mon, 2 Jun 2025 21:50:12 +0800 Subject: [PATCH 1/2] perf(swc/common): rm char_indices --- crates/swc_common/src/input.rs | 40 +++++++++++++++++++--------------- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/crates/swc_common/src/input.rs b/crates/swc_common/src/input.rs index 32cbad246972..45cffd67397b 100644 --- a/crates/swc_common/src/input.rs +++ b/crates/swc_common/src/input.rs @@ -155,16 +155,19 @@ impl<'a> Input<'a> for StringInput<'a> { where F: FnMut(char) -> bool, { - let s = self.iter.as_str(); - let mut last = 0; - - for (i, c) in s.char_indices() { - if pred(c) { - last = i + c.len_utf8(); - } else { - break; + let last = { + let mut last = 0; + for c in self.iter.clone() { + if pred(c) { + last += c.len_utf8(); + } else { + break; + } } - } + last + }; + + let s = self.iter.as_str(); debug_assert!(last <= s.len()); let ret = unsafe { s.get_unchecked(..last) }; @@ -178,19 +181,22 @@ impl<'a> Input<'a> for StringInput<'a> { where F: FnMut(char) -> bool, { - let s = self.iter.as_str(); - let mut last = 0; - - for (i, c) in s.char_indices() { - if pred(c) { - last = i + c.len_utf8(); - break; + let last = { + let mut last = 0; + for c in self.iter.clone() { + last += c.len_utf8(); + if pred(c) { + break; + } } - } + last + }; + if last == 0 { return None; } + let s = self.iter.as_str(); debug_assert!(last <= s.len()); self.last_pos = self.last_pos + BytePos(last as _); From d359585a11abd8ab9d357731ae4f5216b10660e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Donny/=EA=B0=95=EB=8F=99=EC=9C=A4?= Date: Mon, 2 Jun 2025 08:17:01 -0700 Subject: [PATCH 2/2] Create silly-humans-design.md --- .changeset/silly-humans-design.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/silly-humans-design.md diff --git a/.changeset/silly-humans-design.md b/.changeset/silly-humans-design.md new file mode 100644 index 000000000000..3d04271e7751 --- /dev/null +++ b/.changeset/silly-humans-design.md @@ -0,0 +1,6 @@ +--- +swc_core: patch +swc_common: patch +--- + +perf(swc/common): rm char_indices