8000 Comparing Netflix:main...sunykid:master · Netflix/conductor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Netflix/conductor
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: sunykid/conductor
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 20 commits
  • 37 files changed
  • 11 contributors

Commits on Nov 15, 2020

  1. Fix for bug #1961 - fix response codes in posgres and mysql

    @michaelpaliy
    michaelpaliy committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    6116542 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Merge pull request #1970 from michaelpaliy/bugfix/postgres_error_codes 

    Fix for bug #1961 - fix response codes in posgres and mysql
    @apanicker-nflx
    apanicker-nflx authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    cc1f322 View commit details
    Browse the repository at this point in the history

  2. Updated go client to only include domain param when given (#1976) 

    * Updated Ack method to only include the "domain" param if explicitly requested

* Updated PollForTask method to only include the "domain" param if explicitly requested

* Updated logging

* Removed unnecessary log statements
    @djcass44
    djcass44 authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    181c2df View commit details
    Browse the repository at this point in the history

  3. Modified goclient TaskResult struct to push logs to server (#1979) 

    * Modified goclient TaskResult struct to push logs server

* Formatted TaskResult struct

* Added comments
    @bhawani021
    bhawani021 authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    5053afa View commit details
    Browse the repository at this point in the history

  4. add asyncComplete support to Kafka publish task (#1978) 

    * add asyncComplete support to Kafka publish task

* add asyncComplete support to Kafka publish task - update documentation
    @michaelpaliy
    michaelpaliy authored Dec 1, 2020
    Configuration menu
    Copy the full SHA
    4dd2993 View commit details
    Browse the repository at this point in the history

  5. Improve postgresql DAO performance (#1940) 

    * Improve postgresql DAO performance

by adding proper FOR SHARE / FOR UPDATE / SKIP LOCKED locks to DB queries
where it makes sense in order to reduce conflicts/deadlocks in DB.

Most important case is when workers poll for work, they are not
interested in tasks that are locked (currently being updated) so they
can leverage 'SKIP LOCKED' to prevent DB locks and tx deadlocks.

This increases the performance of postgres dao

Additional improvements:

+ move thread.sleep out of DB transaction when tasks are being polled
with timeout parameter

+ add serialization_error to the list of causes triggerring TX retry
(this is happening under heavy load)

+ fix processUnack condition: it used to do the opposite. This has been
also fixed in the meantime by u447 <rick.fishman@bcbsfl.com>

+ add a performance test. This test can be executed manually, but should
not be automated

+ add retries to containsMessage method

Signed-off-by: Maros Marsalek <mmarsalek@frinx.io>

* Remove double query from processUnacks

That was a mistake in the original commit, no need to do the same thing twice
    @marosmars
    marosmars authored Dec 1, 2020

Commits on Dec 2, 2020

  1. Fix for bug 1928, TERMINATE workflowOutput is being override by workf… 

    …lowOutput parameters set from workflowDefinition (#1945)

* Fix for bug 1928, TERMINATE workflowOutput is being override by workflowOutput parameters set from workflowDefinition

* Fix for bug 1928, Fix Build Failure.

* Fix for bug 1928, Fix Integration Build Failure.

* adding unit test coverage

* adding unit test coverage

* Fix for bug 1928, Adding Integration coverage for bug

* removing integration test cases

* adding outputParameters to terminate_task_completed_workflow_integration_test.json file

* Integration test to test output after executing terminate task

* Integration test to test output after executing terminate task

* Fixing Intergartion test and fixing bug in DeciderService rather than chaging workflowDefintion

* Fixing Build Failue

* Removing unused import

* Fix build

* Fixing Build Failue

* Add unit test coverage when definition has outputParameters definied
    @vamsibandarupalli
    vamsibandarupalli authored Dec 2, 2020
    Configuration menu
    Copy the full SHA
    e422baf View commit details
    Browse the repository at this point in the history

  2. ensure cancel tasks when workflow is terminated

    @apanicker-nflx
    apanicker-nflx committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    38c56f5 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Merge pull request #1994 from Netflix/ensure_cancel_task_terminate_wo… 

    …rkflow

ensure cancel tasks when workflow is terminated
    @apanicker-nflx
    apanicker-nflx authored Dec 3, 2020
    Configuration menu
    Copy the full SHA
    954c9a8 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Subworkflow doesn't return output (#1984) 

    * Subworkflow doesn't return output #1849

* Code refactor changes

* #1849 Reviewed code changes
    @sukruthiarjula
    sukruthiarjula authored Dec 8, 2020
    Configuration menu
    Copy the full SHA
    6a0cad8 View commit details
    Browse the repository at this point in the history

  2. Update systask.md 

    `subWorkflowParam` needs to be top level on task of type SUB_WORKFLOW, according to validation.
    @CHURLZ
    CHURLZ authored Dec 8, 2020
    Configuration menu
    Copy the full SHA
    a351d9e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1998 from CHURLZ/patch-1 

    Update systask.md
    @apanicker-nflx
    apanicker-nflx authored Dec 8, 2020
    Configuration menu
    Copy the full SHA
    4bbfa2b View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. added workflows to triage new issues and pull requests

    @apanicker-nflx
    apanicker-nflx committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    9e1bd5a View commit details
    Browse the repository at this point in the history

  2. Update systask.md (#2001)

    @CHURLZ
    CHURLZ authored Dec 9, 2020
    Configuration menu
    Copy the full SHA
    310a6e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Fix for bug #1968 - handle response code in upload PayloadStorage

    @michaelpaliy
    michaelpaliy committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    3feb644 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Merge pull request #2004 from michaelpaliy/bugfix/PayloadStorageCheck… 

    …ResposnseCode

Fix for bug #1968 - handle response code in upload PayloadStorage
    @apanicker-nflx
    apanicker-nflx authored Dec 15, 2020
    Configuration menu
    Copy the full SHA
    0336215 View commit details
    Browse the repository at this point in the history

  2. use github token in workflows

    @apanicker-nflx
    apanicker-nflx committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    f61c8d6 View commit details
    Browse the repository at this point in the history

  3. revert to using personal token

    @apanicker-nflx
    apanicker-nflx committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    86d3c1e View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Error print statement now also prints exec_function name. (#1993)

    @DPain
    DPain authored Dec 22, 2020
    Configuration menu
    Copy the full SHA
    31828bf View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2021

  1. fix project name in gh workflow

    @apanicker-nflx
    apanicker-nflx committed Jan 1, 2021
    Configuration menu
    Copy the full SHA
    e7e4239 View commit details
    Browse the repository at this point in the history
Loading
0