8000 Model 803: missing scaling factor and units for module temperatures · Issue #256 · sunspec/models · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Model 803: missing scaling factor and units for module temperatures #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
IK-Adrian opened this issue Jan 21, 2025 · 1 comment
Open

Model 803: missing scaling factor and units for module temperatures #256

IK-Adrian opened this issue Jan 21, 2025 · 1 comment

Comments

@IK-Adrian
Copy link
IK-Adrian commented Jan 21, 2025 •
edited
Loading

Module temperature points are missing some units and scaling factors. This applies both to the XML and the JSON definitions, but for the context of this issue I will just link the XML as it is shorter:

models/smdx/smdx_00803.xml

Lines 8 to 14 in e9f2fa9

<point id="ModTmpMax" offset="2" type="int16" sf="ModTmp_SF" units="" mandatory="true" />
<point id="ModTmpMaxStr" offset="3" type="uint16" />
<point id="ModTmpMaxMod" offset="4" type="uint16" />
<point id="ModTmpMin" offset="5" type="int16" sf="ModTmp_SF" units="C" mandatory="true" />
<point id="ModTmpMinStr" offset="6" type="uint16" />
<point id="ModTmpMinMod" offset="7" type="uint16" />
<point id="ModTmpAvg" offset="8" type="int16" />

  • ModTmpMax: the units field is empty, should be C.
  • ModTmpMin: correct.
  • ModTmpAvg: both sf and units fields are missing, should be ModTmp_SF and C respectively.

While this may seem to be a small issue, the scaling factor one is pretty relevant, as it breaks implementations that rely on this to automatically format the output.
@IK-Adrian
Copy link
Author

@Kudrat9 would you mind taking a look at this? I was getting one order of magnitude errors in ModTmpAvg measurements and took some time to realize that it was because the scaling factor is not defined in the Model specs.

I can upload a PR with the changes to the JSON file but I don't have the CLA signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IK-Adrian
0