8000 Improve error-handling of get_param_vector(_size) · Issue #75 · stulp/dmpbbo · GitHub

More Web Proxy on the site http://driver.im/

Improve error-handling of get_param_vector(_size) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

stulp opened this issue Aug 21, 2022 · 2 comments

Owner

stulp commented

If not trained, should an error be raised or just don't count it?

Originally posted by @ignacio-pm in #72 (comment)

Owner Author

stulp commented

If calling set_selected_param_names is needed before get_param_vector, I would write more clear here

Originally posted by @ignacio-pm in #72 (comment)

Owner Author

stulp commented

When calling get_param_vector or get_param_vector_size, error-handling behavior should be consistent and documented.

If no parameters are selected, these functions should return [] and 0 respectively. This shoudl be documented.
If function approximators are not trained, something should still be returned. The question is what?

stulp mentioned this issue

With schedules #72

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0