Hints on DmpWithGainSchedules does not yet override Parameterizable interface #61

ignacio-pm · 2022-03-16T10:01:48Z

I am using the DmpWithGainSchedules class to optimize the gains of a DMP. However, the impedance gains are not modified during the rollouts. In line 171 of DmpWithGainSchedules.hpp, there is a TODO left to do. Its description is to override the Parameterizable interface. Thus, the function approximators for gains can not yet be parametrized. This TODO is probably causing the bug of the optimization of the gains. I would appreciate any hint or help on how to tackle the task.

Thanks,

stulp · 2022-03-17T19:15:39Z

It appears the code for doing it is already there:

dmpbbo/src/dmp/DmpWithGainSchedules.hpp

Line 175 in ca900e3

    
             void getSelectableParameters(std::set<std::string>& selectable_values_labels) const;

dmpbbo/src/dmp/DmpWithGainSchedules.cpp

Line 284 in ca900e3

/*

Note sure why it is commented out... Try to comment the code back in and see if it compiles.

In any case, it's important to understand the Parameterizable class in order to understand the design behind it:
https://github.com/stulp/dmpbbo/blob/master/src/functionapproximators/Parameterizable.hpp

I hope to have some time to look at this over the next few days.

stulp · 2022-03-19T07:13:24Z

So the code still compiles, but debugging Eigen (and real-time) code is quite annoying.

@ignacio-pm, is your aim to run this on a real robot? Then the investment may be worth it.

If not, it might in fact be easier to port DmpWithGainSchedules to the python code (see also #60)

ignacio-pm · 2022-03-19T12:32:33Z

I aim to run it in a real robot. However, it does not need to be real-time because the trajectory is calculated before the roll-out. However, the roll-out implementation on the robot is in C++. Therefore, it is convenient to use C++.

I used the demo_robot example as a baseline, initializing the dmpWithGainSchedules, and made the necessary changes. I uncommented the parts you pointed out, but I got an error both in the training (step1A) of the demo_robot folder. The error was on the setSelectedParameters function of the DmpWithGainSchedules. I have not access to the detailed error description now, but I will include it on Monday.

There is an interesting comment here that might explain the cause of the error:

dmpbbo/src/dmp/DmpWithGainSchedules.hpp

Line 171 in ca900e3

    
           /** \todo DmpWithGainSchedules does not yet override Parameterizable interface. Thus, the functionapproximators for the extra dimensions for gains cannot yet be parameterized through this interface.

stulp · 2022-03-19T13:01:07Z

I aim to run it in a real robot. However, it does not need to be real-time because the trajectory is calculated before the roll-out. However, the roll-out implementation on the robot is in C++. Therefore, it is convenient to use C++.

To understand correctly:

A trajectory is generated off-line and written to disk (using dmpbbo code)
The robot reads the trajectory and executes it (you do not use dmpbbo code required for this)

For this scenario, it makes sense to do the first step in python only (it being the easier language to program/debug/visualize results), and doing the second in (realtime) C++ (or whathever your robot needs)

What is blocking you (and others) in doing this, is that not all the functionality in the C++ implementation (e.g.DmpWithGainSchedules) is available in the Python version (see #60). Ergo, if the functionality of the C++ version is ported to the Python version, this would make the code much more usable for many people (I did first steps in d9b0793, but to doing the whole things would require a few days).

What's your time schedule? If you need it quickly I'd suggest that you try to fix the C++ code (Eigen is great, but annoying for these kinds of tasks; that's why I gave up and commented it out). If you have a week or two, we could implement DmpWithGainSchedules in Python (i.e. I would code, you would review). What do you say?

There is an interesting comment here that might explain the cause of the error:

dmpbbo/src/dmp/DmpWithGainSchedules.hpp

Line 171 in ca900e3

/** \todo DmpWithGainSchedules does not yet override Parameterizable interface. Thus, the functionapproximators for the extra dimensions for gains cannot yet be parameterized through this interface.

Indeed. I would thus say that it is not an error per se, but a lack of functionality.

Side remark: if you generate trajectories off-line (as many people do), you do not have any of the advantages of DMPs (adaptation to the changing goals or unexpected perturbations). In this "off-line" case, one could also use splines.

ignacio-pm · 2022-03-19T13:33:23Z

To understand correctly:

A trajectory is generated off-line and written to disk (using dmpbbo code)

The robot reads the trajectory and executes it (you do not use dmpbbo code required for this)

That is what I meant, and therefore, I think python makes sense in this case. I already have both steps running in C++ using your demo_robot code as a baseline, but the transfer to python will not take long.

My time schedule is tight; I want to finish everything to start experiments this week or the next one. I will try to fix the C++ code, but I am open to helping/reviewing the python code because I might not be able to solve it, and it could be helpful for the future.

stulp · 2022-03-19T13:42:36Z

Given a tight schedule, I consider the "porting to python approach" risky. Then chances are better getting the C++ code running.

Do you want to optimized DMP trajectories and gain schedules at the same time, or only gain schedules?

ignacio-pm · 2022-03-19T13:47:20Z

Both. I want to compare optimizing only the DMP trajectories with optimizing the gain schedules and the DMP trajectories for a given task.

stulp · 2022-03-19T15:03:09Z

So I had a look and it is complicated.

What speaks against doing this in C++
- the Parameterizable needs a refactoring. I'm not happy with my design decisions back then. (big task: Refactor Parameterizable in C++ #63)
Against doing it in Python
- there is only a minimal implementation of DMPs (without gain scheduling) (big task: Refactoring Python/C++ redundancy #60 )
- implementing gain scheduling in Python would not be so difficult, but robot_demo currently assumes a C++ implementation of the DMPs (big task: Implement robot_demo_traj #62 )

So I've opened new issues for these subtasks in #62 and #63, but unfortunately, those are not going to be done in a week or two (probably I need one whole week for them and #45 and #60, but I do not know when I will have that week).

stulp · 2022-03-20T09:07:11Z

So I did a quick feasability analysis:

I started addressing Refactoring Python/C++ redundancy #60 in ba33e38. Indeed it is not trivial, and I had to stop.
I started with Implement robot_demo_traj #62 in 16b7241. This will also take one full day, which I do not have at the moment.

Thanks for nudging me to address these issues that I had wanted to work on anyway. But they require larger changes for which I will not have time before your deadline.

ignacio-pm · 2022-03-20T19:48:01Z

Thank you for your work!

stulp · 2022-03-21T21:25:29Z

You're welcome!

So I went for #63 anyway. 9d4e23e It is available in the branch cpp_parameterizable.

Parameterization now works for the LWR and RBFN function approximators (tested both with testPerturbModelParameterLWR.cpp). Also seems to be working for DMP (tested with testDmpModelParameterValues.cpp).

It compiles for DmpWithGainSchedules also, but I haven't tested it yet... It's worth a shot for your experiment. But it's not in the master branch yet because I haven't tested it yet.

The more long-term solution is #62 in any case.

ignacio-pm · 2022-03-22T11:11:47Z

I will test it in my experiment between today and tomorrow and tell you if it works

ignacio-pm · 2022-03-23T22:49:07Z

So I gave a try and I had to fix a couple things before I got it to work, which are in the Pull Request: #65 . Before merging there are a couple things that needs to be decided (explained in the PR).

stulp · 2022-03-24T06:48:24Z

There's just one minor fix that's required before merging it (i.e. undoing some changes that you had to make because a function was not implemented yet, but are now available in 876ed29)

When the PR is merged, it's essential to do some basic testing of DmpWithGainSchedules. For that, I would copy this one
https://github.com/stulp/dmpbbo/blob/master/src/dmp/tests/testDmpModelParameterValues.cpp
to a test called testDmpWithGainSchedulesModelParameterValues. The test should confirm that:

gain schedules can be changed without changing the function approximators (FAs) for the transformation systems in Dmp (i.e. by selecting parameters "offsets_gains" for LWR (choose "weights_gains" when using RBFN)
FAs in the Dmp can be changed with chanding the gain schedule FAs (select "weights")
both can be changed at the same time (select "weights" and "weights_gains")

Small hint: I find working with RBFNs much more intuitive when visualizing and debugging. And in practice, I've not seen advantages of using LWR.

stulp · 2022-03-25T07:02:55Z

In demo_robot, it is now possible to use DmpWithGainSequences: f840411

This commit allows the easy switching on/off of which parameters are optimized: f32a0e7

This code compiles, and looking at the dmp.xml file that step1A_trainDmpFromTrajectoryFile generates, it appears to do the right thing. I've not had time to run dmp.xml in step 2..4 of robot_demo yet though, so it is not properly tested yet.

stulp · 2022-06-19T07:30:41Z

@ignacio-pm There is a new issue (and branch) specifically dedicated to the reimplementation of Dmps with gain/force schedules? Shall we close this issue?

You had previously offered to review the code related to this? Can I assign you as review to a PR for the branch with_schedules, once it is done?

ignacio-pm · 2022-06-24T13:19:21Z

@stulp, yes, you can assign me, and I can review the code, but I am no longer in the project I was using this repository, so I can not test it on my experiment.

This was referenced Mar 19, 2022

Implement robot_demo_traj #62

Closed

Refactor Parameterizable in C++ #63

Closed

ignacio-pm closed this as completed Jun 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hints on DmpWithGainSchedules does not yet override Parameterizable interface #61

Hints on DmpWithGainSchedules does not yet override Parameterizable interface #61

Hints on DmpWithGainSchedules does not yet override Parameterizable interface #61

Hints on DmpWithGainSchedules does not yet override Parameterizable interface #61

Comments