8000 Allow for `config.authenticator` to be optional · Issue #36 · strangerlabs/webauthn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Allow for config.authenticator to be optional #36
New issue
New issue
Open
Open
Allow for config.authenticator to be optional#36
@magom001

Description

@magom001
magom001
opened on Jul 11, 2020

Currently AttestationChallengeBuilder.setAuthenticator throws an error if config.authenticator is not cross-platform or platform

This field is not mandatory. If not provided a browser prompt is presented (@see https://webauthn.io/).

I suggest to remove

webauthn/src/AttestationChallengeBuilder.js

Lines 157 to 161 in d8d63d2

const values = Object.values(Dictionaries.AuthenticatorAttachment)
if (!values.includes(authenticatorAttachment)) {
throw new Error(`Invalid AuthenticatorAttachment value. Must be one of "${values.join('", "')}".`)
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0