8000 User avatar in control panel header does not cover whole circle if avatar image aspect ratio is not 1:1 · Issue #5729 · statamic/cms · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

User avatar in control panel header does not cover whole circle if avatar image aspect ratio is not 1:1 #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ncla opened this issue Apr 3, 2022 · 3 comments · Fixed by #5731
Closed

User avatar in control panel header does not cover whole circle if avatar image aspect ratio is not 1:1 #5729

ncla opened this issue Apr 3, 2022 · 3 comments · Fixed by #5731
Labels
ui

Comments

@ncla
Copy link
Contributor
ncla commented Apr 3, 2022 •
edited
Loading

Bug description

image

How to reproduce

  1. Upload an avatar that is in some weird aspect ratio for currently logged in user

Logs

No response

Versions

Statamic 3.3.4
Laravel 9.5.1
PHP 8.0.16
No addons installed

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

No response

Additional details

I can open PR for this, there's two approaches for this:

  1. One line CSS fix
  2. Force generate a square thumbnail (currently CP outputs URL to the original image)
@ncla ncla changed the title User avatar in control panel header does not cover whole circle if avatar image aspect ratio is not 1:1 ratio User avatar in control panel header does not cover whole circle if avatar image aspect ratio is not 1:1 Apr 3, 2022
@arthurperton
Copy link
Contributor

Nice find. I would go for the CSS fix.

This was referenced Apr 3, 2022
Closed
Merged
@ncla
Copy link
Contributor Author
ncla commented Apr 3, 2022

Since I already had looked at how to solve this issue before hand (I know, I know), I present two PRs. One CSS fix, second one uses thumbnail controller adjustments. CSS fix is much simpler obviously. As I said in the 2nd PR, no hard feelings if it's too much, just deep diving cms source code as practice.

@arthurperton
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
3 participants
@arthurperton @ncla @duncanmcclean
0