8000 Refreshing balances should derive new xpubkey addresses and check to see if there were deposits · Issue #1830 · rotki/rotki · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refreshing balances should derive new xpubkey addresses and check to see if there were deposits #1830

Closed
coblee opened this issue Nov 28, 2020 · 1 comment · Fixed by #4731
Closed

Refreshing balances should derive new xpubkey addresses and check to see if there were deposits #1830

coblee opened this issue Nov 28, 2020 · 1 comment · Fixed by #4731
Assignees
@prettyirrelevant
Labels
bitcoin
Milestone
v1.26.0 8000

Comments

@coblee
Copy link
Contributor
coblee commented Nov 28, 2020

Abstract

When you refresh balances, you should check to see if there were coins sent to new addresses of xpubkeys

Motivation

People with xpubkeys will occasionally deposit coins to new derived addresses. It's important that refreshing balances catches those.

Specification
@LefterisJP LefterisJP added this to the v1.10.0 milestone Nov 28, 2020
@LefterisJP LefterisJP modified the milestones: v1.10.0, v1.11.0 Dec 11, 2020
@LefterisJP LefterisJP modified the milestones: v1.11.0, v1.14.0 Dec 30, 2020
@LefterisJP LefterisJP modified the milestones: v1.14.0, v1.15.0 Feb 13, 2021
@LefterisJP LefterisJP modified the milestones: v1.15.0, v1.16.0 Mar 8, 2021
@LefterisJP LefterisJP modified the milestones: v1.16.0, v1.17.0 Mar 22, 2021
@rotki rotki deleted a comment from codyday318 May 3, 2021
@LefterisJP LefterisJP modified the milestones: v1.17.0, v1.18.0 May 26, 2021
@LefterisJP LefterisJP modified the milestones: v1.18.0, v1.19.0 Jun 17, 2021
@LefterisJP LefterisJP modified the milestones: v1.19.0, v1.20.0 Jul 14, 2021
@LefterisJP LefterisJP modified the milestones: v1.20.0, v1.22.0 Aug 3, 2021
@LefterisJP LefterisJP modified the milestones: v1.22.0, v1.23.0 Nov 13, 2021
@LefterisJP LefterisJP modified the milestones: v1.23.0, v1.25.0 Dec 24, 2021
@LefterisJP LefterisJP modified the milestones: v1.25.0, v1.26.0 Jul 15, 2022
@LefterisJP
Copy link
Member

This is easy. Let's just implement it in next release

@prettyirrelevant prettyirrelevant self-assigned this Aug 22, 2022
@prettyirrelevant prettyirrelevant mentioned this issue Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prettyirrelevant prettyirrelevant

Labels
bitcoin
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging a pull request may close this issue.

derive new addresses from xpubs when balances are refreshed prettyirrelevant/rotki
3 participants
@coblee @LefterisJP @prettyirrelevant
0