8000 Re-enable transaction events filtering · Issue #4438 · rotki/rotki · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable transaction events filtering #4438

Closed
LefterisJP opened this issue Jun 5, 2022 · 0 comments · Fixed by #4552
Closed

Re-enable transaction events filtering #4438

LefterisJP opened this issue Jun 5, 2022 · 0 comments · Fixed by #4552
Assignees
Milestone

Comments

@LefterisJP
Copy link
Member

Abstract

With 1.24.1 we disable transactions event filtering due to: #4379

We need to fix the underlying cause (bad DB design) and re-enable it.

Task

  1. Fix the DB schema. We should force bytes for tx_hash everywhere since this really helps with size. A transaction hash is 32 bytes when stored as blob. But if stored as text it's (32 * 2 + 2) = 66 characters, so 528 bytes per hash. The difficult part here will be that we will also need to switch to using a bytes event_identifier for historical base entries.
  2. Undo most of the work done here: Temporarily remove transaction event filtering from the backend #4432
  3. Undo most of the work done here: Disables transaction filtering in frontend #4431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
0