Backport - Provide copy and move constructors for model (#33)
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4b73ae2 the copy and move constructors were accidentally disabled. This means that one must always wrap a `urdf::Model` into some form of pointer in order to pass it around or have it as a member. This commit restores the copy and move constructors, such that one is able to pass the `urdf::Model` around as a normal variable. See also: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rc-five Co-authored-by: Shane Loretz <sloretz@osrfoundation.org>
ahcorde
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #33, so copy and move are available in humble too.
These changes should be API/ABI compatible.
These constructors are available in ros 1 noetic and ros 2 iron onwards, just missing in humble