-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmetic fixes for ros2param dump command. #933
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@clalancette could you take a look? |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Pulls: #933 |
@sloretz CI is green, could you review? |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor fix, then I think this looks good.
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with green CI.
@Mergifyio backport humble iron jazzy |
✅ Backports have been created
|
* cosmetic fixes for ros2param dump command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * pass through no parameters available case. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * bug fix from review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * remove unnecessary initial assignment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 8e46bf2) # Conflicts: # ros2param/ros2param/verb/dump.py
* cosmetic fixes for ros2param dump command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * pass through no parameters available case. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * bug fix from review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * remove unnecessary initial assignment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 8e46bf2)
* cosmetic fixes for ros2param dump command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * pass through no parameters available case. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * bug fix from review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * remove unnecessary initial assignment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 8e46bf2)
* cosmetic fixes for ros2param dump command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * pass through no parameters available case. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * bug fix from review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * remove unnecessary initial assignment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 8e46bf2) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
* cosmetic fixes for ros2param dump command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * pass through no parameters available case. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * bug fix from review comment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * remove unnecessary initial assignment. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 8e46bf2) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This reverts commit 8e46bf2. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
closes #930
replaces #931