[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic fixes for ros2param dump command. #933

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

fujitatomoya
Copy link
Collaborator

closes #930

replaces #931

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@clalancette could you take a look?

@fujitatomoya fujitatomoya self-assigned this Sep 16, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

Pulls: #933
Gist: https://gist.githubusercontent.com/fujitatomoya/26e84d2c1dd65ac3bc6ac4ce41d96a89/raw/2ac6489ad24ed7fefa8115f92d9ea3b3b88f64c4/ros2.repos
BUILD args: --packages-above-and-dependencies ros2param
TEST args: --packages-above ros2param
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14574

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@sloretz CI is green, could you review?

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Contributor
@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor fix, then I think this looks good.

ros2param/ros2param/verb/dump.py Outdated Show resolved Hide resolved
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Contributor
@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@fujitatomoya fujitatomoya merged commit 8e46bf2 into rolling Oct 3, 2024
3 checks passed
@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport humble iron jazzy

Copy link
mergify bot commented Oct 3, 2024

backport humble iron jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 3, 2024
* cosmetic fixes for ros2param dump command.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* pass through no parameters available case.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* bug fix from review comment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* remove unnecessary initial assignment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8e46bf2)

# Conflicts:
#	ros2param/ros2param/verb/dump.py
mergify bot pushed a commit that referenced this pull request Oct 3, 2024
* cosmetic fixes for ros2param dump command.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* pass through no parameters available case.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* bug fix from review comment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* remove unnecessary initial assignment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8e46bf2)
mergify bot pushed a commit that referenced this pull request Oct 3, 2024
* cosmetic fixes for ros2param dump command.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* pass through no parameters available case.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* bug fix from review comment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* remove unnecessary initial assignment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8e46bf2)
@clalancette clalancette deleted the fujitatomoya/ros2param-dump-fix branch October 3, 2024 17:36
fujitatomoya added a commit that referenced this pull request Oct 4, 2024
* cosmetic fixes for ros2param dump command.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* pass through no parameters available case.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* bug fix from review comment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* remove unnecessary initial assignment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8e46bf2)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit that referenced this pull request Oct 4, 2024
* cosmetic fixes for ros2param dump command.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* pass through no parameters available case.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* bug fix from review comment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

* remove unnecessary initial assignment.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 8e46bf2)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya added a commit to fujitatomoya/ros2cli that referenced this pull request Oct 17, 2024
This reverts commit 8e46bf2.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ros2 param dump UnboundLocalError
4 participants