feat(echo --clear): add --clear option to echo #819
Conversation
I had the same failure with the HEAD of rolling for this repo. I had to rebuild all rolling from source for them to pass. |
Yes, that's correct, though as of yesterday, they are the same thing. That said, these tests have indeed been flaky here for a while, and we haven't had time to track it down. So I wouldn't worry about those two in particular right now. |
|
Does that PR require further changes? |
Yes, we need to come to a conclusion on this discussion. |
Signed-off-by: Guillaumebeuzeboc <guillaume.beuzeboc@gmail.com>
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
b558df7 to
6e99313
Compare
|
Pulls: #819
|
|
Okay the CI is failing with the following error. (my local environment which does have the terminal environment, there is no problem) https://ci.ros2.org/job/ci_linux/21981/testReport/junit/ros2topic.ros2topic.test/test_cli/test_cli/ Traceback (most recent call last):
File "/home/jenkins-agent/workspace/ci_linux/ws/install/launch_testing/lib/python3.12/site-packages/launch_testing/markers.py", line 61, in _wrapper
return func(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/jenkins-agent/workspace/ci_linux/ws/src/Guillaumebeuzeboc/ros2cli/ros2topic/test/test_cli.py", line 411, in test_topic_echo_clear
assert topic_command.wait_for_output(functools.partial(
AssertionError: Output does not match: 'unknown': unknown terminal type.
data: 'Hello World: 78'
---
'unknown': unknown terminal type.
data: 'Hello World: 79'
---I think we need to check if the terminal environmental variable is there with checking |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
I ended up not having the test case for this because of #819 (comment) and checking the escape sequence generates unterminated error during check. |
|
Pulls: #819
|
Adds the
--clear/-coption to echo.Solves this issue: #725
This was previously available in ROS.
This clears the screen before a new message is displayed.
ESC[2Jcorresponds toerase entire screenESC[Hcorresponds tomoves cursor to home position (0, 0)I had to build rolling from source to successfully run the tests