Add timeout to kill hanging tests #701
Conversation
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
There was a problem hiding this comment.
This generally looks good to me, though we need to get ros2/ci#632 in first and I'd also like to see CI (especially on Windows) with this in place. Once those things are done, I'm happy to approve.
|
Running CI:
|
|
I am not sure why linux CIs are failing to import virtualenv, retry CI.
|
|
This particular one is special because it changes CI. Because of the Ubuntu Jammy Python 3.9 -> 3.10 transition, we aren't quite ready for changes to CI. Once the freeze is over (today), we should have fixes for the Python transition and then we'll be able to run CI here. |
|
FYI @Blast545 as this will change the failure mode of hanging ros2cli tests. |
|
@audrow FYI, it should now be possible to move forward with this. You'll have to rebase ros2/ci#632 onto master, but with that done you should be able to run CI successfully. |
|
Another CI run after rebasing the ros2/ci#632.
|
This PR aims to remedy our buildfarm jobs that occasionally hang until they are manually killed.
This requires the following PR: ros2/ci#632.
You can see that the timeout worked to stop a job here (with absurdly low timeout): https://ci.ros2.org/job/ci_linux/16355/console#console-section-5.