[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[galactic backport] Fix flaky ros2 param list (#656) #663

Merged
merged 1 commit into from
Sep 9, 2021
Merged

[galactic backport] Fix flaky ros2 param list (#656) #663

merged 1 commit into from
Sep 9, 2021

Conversation

jacobperron
Copy link
Member

Backport #656 to Galactic

@jacobperron
Fix flaky ros2 param list (#656)
eb4e8cf 
* Use daemon for listing parameter services

This helps avoid incomplete parameter lists due to races with discovery.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Retry list verb test

It's possible that the first invocation of 'ros2 param list' does not return a complete parameter list
as there may not have been enough time for discovery.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Lint

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron self-assigned this Aug 31, 2021
@jacobperron
Copy link
Member Author
jacobperron commented Aug 31, 2021 •
edited
Loading
  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 313d4bf into galactic Sep 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the jacob/galactic_backport_656 branch September 9, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @audrow