[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix for #563 #570

Merged
merged 1 commit into from
Feb 12, 2021
Merged

bugfix for #563 #570

merged 1 commit into from
Feb 12, 2021

Conversation

daisukes
Copy link
Contributor

Use argcomplete's split_line to deal with incomplete quote states.

Signed-off-by: Daisuke Sato daisukes@cmu.edu

@clalancette clalancette self-assigned this Nov 5, 2020
clalancette
clalancette reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor
@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable enough to me. @claireyywang @mabelzhang can one of you review this, and maybe test out to make sure things still work both with argcomplete installed and with it not installed?

ros2cli/ros2cli/command/__init__.py Show resolved Hide resolved
@artivis artivis mentioned this pull request Nov 13, 2020
Merged
@clalancette
Copy link
Contributor
clalancette commented Feb 4, 2021 •
edited
Loading

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

@daisukes I'd love to get this in. However, it looks like it is causing some failures in the test_list_ tests in CI. Would you mind taking a look?

@daisukes
Copy link
Contributor Author

@clalancette, sorry for the late response. I'm going to look into it!

@clalancette
Copy link
Contributor

@clalancette, sorry for the late response. I'm going to look into it!

Thanks, appreciated!

@daisukes
Copy link
Contributor Author

I've checked the log of the CI and found the error.

FAIL: test_cli.TestROS2TopicCLI.test_topic_endpoint_info_verbose[rmw_fastrtps_cpp]

However, this can happen with the previous commit 56db2ba of mine.
Also, I tested my patch with the current master, and the patch does not introduce any new error.

The error is caused by the unexpected output of the ros2 topic info -v /chatter command.
It seems like this commit fixed the error.
2b6930e

@claireyywang
Copy link
Contributor

CI
Linux Build Status
Linux-aarch64 Build Status
macOS Build Status
Windows Build Status

@daisukes @clalancette
bugfix for ros2#563
c68ac42 
Signed-off-by: Daisuke Sato <daisukes@cmu.edu>
@clalancette
Copy link
Contributor

The error is caused by the unexpected output of the ros2 topic info -v /chatter command.
It seems like this commit fixed the error.

Ah, good point. I've just rebased this branch onto master, and here is another run at CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

All right, CI is happy. The PR job is failing, but that doesn't seem to be unique to this job. @daisukes Thanks for the contribution, and sorry this took so long to get in. Merging.

@clalancette clalancette merged commit d864a36 into ros2:master Feb 12, 2021
This was referenced Feb 12, 2021
Closed
Closed
@clalancette clalancette mentioned this pull request Mar 10, 2021
Closed
fujitatomoya pushed a commit to fujitatomoya/ros2cli that referenced this pull request Mar 14, 2021
@daisukes @fujitatomoya
bugfix for ros2#563 (ros2#570)
4f079ca 
Signed-off-by: Daisuke Sato <daisukes@cmu.edu>
@fujitatomoya fujitatomoya mentioned this pull request Mar 14, 2021
Merged
fujitatomoya pushed a commit to fujitatomoya/ros2cli that referenced this pull request Mar 14, 2021
@daisukes @fujitatomoya
bugfix for ros2#563 (ros2#570)
a1c1f4d 
Signed-off-by: Daisuke Sato <daisukes@cmu.edu>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
audrow pushed a commit that referenced this pull request Mar 19, 2021
@fujitatomoya @daisukes
bugfix for #563 (#570) (#609)
24f76be 
Signed-off-by: Daisuke Sato <daisukes@cmu.edu>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

Co-authored-by: Daisuke Sato <43101027+daisukes@users.noreply.github.com>
@fujitatomoya fujitatomoya mentioned this pull request Jan 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daisukes @clalancette @claireyywang