support QoS Depth and History via ros2 topic pub/echo. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
|
could you take a look at this? |
I will take a look, but I'd prefer to first fix the depth problem as discussed in #523 (comment) in first. |
clalancette
requested changes
Jun 15, 2020
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
clalancette
requested changes
Jun 16, 2020
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
|
sorry to disturb you once again, could you take a look at https://github.com/ros2/ros2cli/pull/528/files/11020132e4efc1ecf7d4b0f96fcf099b6678b95c..a4e73056a2fad85525f715e666fff73341a62e01 ? |
clalancette
approved these changes
Jun 17, 2020
|
CI:
|
|
@fujitatomoya It looks like tests are failing with flake8 errors. Can you take a look? |
|
i will check it and get back to you. |
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
|
fix flake8 code style, confirmed with |
|
looks all green, do we have a go? |
|
Here's new CI. Assuming it goes green, I'll merge:
|
craigh92
pushed a commit
to craigh92/ros2cli
that referenced
this pull request
Jul 17, 2020
* support QoS Depth and History via ros2 topic pub/echo. Also keep depth at least 1 with transient_local setting. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Craig Hickman <craig.hickman@ukaea.uk>
bergercookie
pushed a commit
to bergercookie/ros2cli
that referenced
this pull request
Nov 18, 2021
* support QoS Depth and History via ros2 topic pub/echo. Also keep depth at least 1 with transient_local setting. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
bergercookie
pushed a commit
to bergercookie/ros2cli
that referenced
this pull request
Nov 18, 2021
* support QoS Depth and History via ros2 topic pub/echo. Also keep depth at least 1 with transient_local setting. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Nikos Koukis <nickkouk@gmail.com>
clalancette
pushed a commit
that referenced
this pull request
Nov 29, 2021
* support QoS Depth and History via ros2 topic pub/echo. Also keep depth at least 1 with transient_local setting. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Nikos Koukis <nickkouk@gmail.com> Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #523
Signed-off-by: Tomoya.Fujita Tomoya.Fujita@sony.com