use f-string #448
Merged
use f-string #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
commented
Feb 1, 2020
| @@ -140,16 +136,13 @@ def call_get_parameters(*, node, node_name, parameter_names): | |||
| if response is None: | |||
| e = future.exception() | |||
| raise RuntimeError( | |||
| 'Exception while calling service of node ' | |||
| "'{args.node_name}': {e}".format_map(locals())) | |||
| f"Exception while calling service of node '{node_name}': {e}") | |||
There was a problem hiding this comment.
Great example why f-strings are better: this bug was catched by the linters (before the string contained args.node_name but args isn't a variable in the current scope.
Same below in old line 170 / new line 162.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds in ament/ament_package#112.