Fix test linking issues on Windows #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dirk-thomas
reviewed
Oct 8, 2018
include/message_filters/cache.h
Outdated
| @@ -272,12 +272,12 @@ class Cache : public SimpleFilter<M> | |||
|
|
|||
| MConstPtr out ; | |||
|
|
|||
| int i=cache_.size()-1 ; | |||
| size_t i=cache_.size()-1 ; | |||
There was a problem hiding this comment.
This change makes the condition in the while loop (i>=0) obsolete. When cache_ is empty a rollover would occur.
There was a problem hiding this comment.
Yes, I'll go back and verify anywhere that I made signedness changes.
test/msg_cache_unittest.cpp
Outdated
| @@ -135,7 +135,7 @@ TEST(Cache, easySurroundingInterval) | |||
| } | |||
|
|
|||
|
|
|||
| std::shared_ptr<Msg const> buildMsg(double time, int data) | |||
| std::shared_ptr<Msg const> buildMsg(int32_t time, int data) | |||
There was a problem hiding this comment.
Should the argument be named seconds?
There was a problem hiding this comment.
Yes, also is there a reason that we don't have a double constructor for time in ROS2?
There was a problem hiding this comment.
is there a reason that we don't have a
doubleconstructor for time in ROS2?
Probably just not implemented yet.
|
|
@tfoote I believe after this, we should be able to put this in ros2.repos for CI. |
|
Fixed a fat-finger:
|
chapulina
approved these changes
Oct 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9 by correctly depending on ament_cmake_ros as well as general cleaning of Windows-specific warnings.