[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SetROSLogDir action #325

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

wjwwood
Copy link
Member
@wjwwood wjwwood commented Sep 23, 2022

This action can be used to change the ROS log dir for any processes started after this action that contain ROS nodes.

It can be scoped when used in conjunction with the launch.actions.GroupAction action.

Requires ros2/launch#652

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
Copy link
Member Author
wjwwood commented Sep 23, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Member
@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI!

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood requested a review from jacobperron September 23, 2022 21:05
Copy link
Member
@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI

Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
Copy link
Member Author
wjwwood commented Sep 24, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit 1ec2fe6 into rolling Sep 26, 2022
@wjwwood wjwwood deleted the feature/nest_node_log_files_in_launch_log_dir branch September 26, 2022 20:30
@hakunaMatataHub
Copy link

@wjwwood Hi, which is the oldest release that has these changes? I am on foxy now with patch9. Are they on foxy or will I have to shift the Distro to a more latest one? Which one has it?

@clalancette
Copy link
Contributor

@wjwwood Hi, which is the oldest release that has these changes? I am on foxy now with patch9. Are they on foxy or will I have to shift the Distro to a more latest one? Which one has it?

The only release that currently has these changes is Rolling.

@hakunaMatataHub
Copy link

@wjwwood Thank you for the swift response. I was wondering whether this commit will also allow to control the log file names. The use case arises from the fact that it may be subjective to the developer to decide what meta/contextual information to have in the file name. For example I would want to control it because I would want to have version of my code as a part of the log file name using which I can filter the files to input to a log parsing pipiline.

@wjwwood
Copy link
Member Author
wjwwood commented Feb 15, 2023

@hakunaMatataHub No this command only lets you control the folder into which the the logs will be created. The log file names are generated based on the name of the process and as of right now there is no way that I know of to control the file name manually.

You could, however, insert any information you'd like into the folder name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants