-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SetROSLogDir action #325
add SetROSLogDir action #325
Conversation
Signed-off-by: William Woodall <william@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI!
Signed-off-by: William Woodall <william@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending CI
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood Hi, which is the oldest release that has these changes? I am on foxy now with patch9. Are they on foxy or will I have to shift the Distro to a more latest one? Which one has it? |
The only release that currently has these changes is Rolling. |
@wjwwood Thank you for the swift response. I was wondering whether this commit will also allow to control the log file names. The use case arises from the fact that it may be subjective to the developer to decide what meta/contextual information to have in the file name. For example I would want to control it because I would want to have version of my code as a part of the log file name using which I can filter the files to input to a log parsing pipiline. |
@hakunaMatataHub No this command only lets you control the folder into which the the logs will be created. The log file names are generated based on the name of the process and as of right now there is no way that I know of to control the file name manually. You could, however, insert any information you'd like into the folder name. |
This action can be used to change the ROS log dir for any processes started after this action that contain ROS nodes.
It can be scoped when used in conjunction with the
launch.actions.GroupAction
action.Requires ros2/launch#652