8000 Fix ComposableNode ignoring PushRosNamespace actions by ivanpauno · Pull Request #162 · ros2/launch_ros · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ComposableNode ignoring PushRosNamespace actions #162

Merged
merged 9 commits into from
Jul 15, 2020
Merged

Fix ComposableNode ignoring PushRosNamespace actions #162

merged 9 commits into from
Jul 15, 2020

Conversation

ivanpauno
Copy link
Member

Fixes #159.

I refactored common namespace handling logic in a utilities module.

ivanpauno added 3 commits July 14, 2020 11:30
@ivanpauno
Refactor: put namespace handling logic in a common module
233c07e 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Composable nodes should not ignore the pushed namespace
98ae296 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Move old tests under utilities subfolder when applies
81a1e00 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the bug Something isn't working label Jul 14, 2020
@ivanpauno ivanpauno requested a review from hidmic July 14, 2020 14:35
@ivanpauno ivanpauno self-assigned this Jul 14, 2020
@ivanpauno
Please linters
ca9824c 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
hidmic approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor
@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

ivanpauno and others added 4 commits July 14, 2020 14:47
@ivanpauno @hidmic
Fix nit
0adb652 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
@ivanpauno @hidmic
Correct grammar
90d787d 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
@ivanpauno
Fix nits in docblock
a6f9640 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Address peer review comments
ca39eda 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Remove references to return_absolute_ns argument
5c22c0f 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

Rpr checker is passing, merging!

@ivanpauno ivanpauno merged commit 2fa8f00 into master Jul 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-push-ros-namespace-composable-node branch July 15, 2020 20:33
jacobperron pushed a commit that referenced this pull request Nov 19, 2020
@ivanpauno @jacobperron
Fix ComposableNode ignoring PushRosNamespace actions (#162)
f0a3ce0 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@jacobperron jacobperron mentioned this pull request Nov 19, 2020
Merged
jacobperron pushed a commit that referenced this pull request Nov 20, 2020
@ivanpauno @jacobperron
Fix ComposableNode ignoring PushRosNamespace actions (#162)
5ddc676 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron added a commit that referenced this pull request Nov 20, 2020
@jacobperron @ivanpauno
Fix ComposableNode ignoring PushRosNamespace actions (#162) (#201)
ce19fed 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@ivanpauno ivanpauno

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PushRosNamespace action should affect ComposableNode descriptions
2 participants
@ivanpauno @hidmic
0