Split tf2_ros in tf2_ros and tf2_ros_py #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
Jan 13, 2020
5c617e8 to
80e49cc
Compare
clalancette
requested changes
Jan 17, 2020
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
9939f2a to
7af068d
Compare
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
All right, I reworked the tests here to succeed, and I've converted this to a pure Python package. I'm going to do a self-review and run CI, but @ahcorde it would be good if you could take a look here. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
clalancette
approved these changes
Jun 10, 2020
ahcorde
commented
Jun 11, 2020
| goal.timeout = timeout.to_msg() | ||
| goal.advanced = False | ||
|
|
||
| return self.__process_goal(goal) | ||
|
|
||
| # lookup, advanced api | ||
| # lookup, advanced api | ||
| def lookup_transform_full(self, target_frame, target_time, source_frame, source_time, fixed_frame, timeout=Duration()): | ||
| """ | ||
| Get the transform from the source frame to the target frame using the advanced API. | ||
|
|
||
| :param target_frame: Name of the frame to transform into. |
There was a problem hiding this comment.
:type *: is not defined as well as :rtype: . Should we open a ticket?
There was a problem hiding this comment.
Yeah, good call. I'll open an issue to follow-up and add those annotations.
This was referenced Jun 11, 2020
|
All right, CI was green, added a note to the release page. Merging in, thanks for the review. |
This was referenced Jul 22, 2020
jacobperron
added a commit
that referenced
this pull request
Aug 14, 2020
This is a backport of the change made during the split of packages in #210. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Aug 14, 2020
This is a backport of the change made when splitting out the Python module into its own packages in #210. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Aug 18, 2020
This is a backport of the change made when splitting out the Python module into its own packages in #210. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this issue #169 I splitted
tf2_rosin 2 packages: