[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused setup.py files #190

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Remove unused setup.py files #190

merged 1 commit into from
Nov 19, 2019

Conversation

vasart
Copy link
Contributor
@vasart vasart commented Oct 29, 2019

Closes #174

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

Thanks for the contribution! This is now ready to go, but we'll hold off merging it until after we branch off for Eloquent.

@dirk-thomas
Copy link
Member

we'll hold off merging it until after we branch off for Eloquent.

@clalancette Why holding the merge? These are CMake packages - the setup.py files are not used anywhere.

@mjcarroll mjcarroll mentioned this pull request Nov 15, 2019
Merged
@tfoote
Copy link
Contributor
tfoote commented Nov 18, 2019

@ros-pull-request-builder retest this please

@tfoote tfoote merged commit 3fd31f7 into ros2:ros2 Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused setup.py files
5 participants
@vasart @clalancette @dirk-thomas @tfoote @sloretz