[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teleop_turtle_key] update usage string to match keys captured by key… (backport #165) #166

Merged
merged 1 commit into from
May 6, 2024
Merged

[teleop_turtle_key] update usage string to match keys captured by key… (backport #165) #166

merged 1 commit into from
May 6, 2024

Conversation

mergify[bot]
Copy link
@mergify mergify bot commented May 6, 2024

…board

The keys actually captured in the code are the lowercase versions:

ros_tutorials/turtlesim/tutorials/teleop_turtle_key.cpp

Lines 53 to 62 in fa28686

static constexpr char KEYCODE_B = 0x62;
static constexpr char KEYCODE_C = 0x63;
static constexpr char KEYCODE_D = 0x64;
static constexpr char KEYCODE_E = 0x65;
static constexpr char KEYCODE_F = 0x66;
static constexpr char KEYCODE_G = 0x67;
static constexpr char KEYCODE_Q = 0x71;
static constexpr char KEYCODE_R = 0x72;
static constexpr char KEYCODE_T = 0x74;
static constexpr char KEYCODE_V = 0x76;

On Windows it will still be the uppercase version but I suppose it is the case for case insensitive shells so this change in help string shouldn't impact the users

This is an automatic backport of pull request #165 done by Mergify.

@mikaelarguedas @mergify
[teleop_turtle_key] update usage string to match keys captured by key…
91db6cf 
…board (#165)

On windows it will stay uppercase but shouldn't impact users compared to
current situation

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
(cherry picked from commit e2853ca)
@mergify mergify bot requested a review from ahcorde as a code owner May 6, 2024 21:16
@mergify mergify bot mentioned this pull request May 6, 2024
Merged
@ahcorde ahcorde merged commit e7e7091 into jazzy May 6, 2024
3 checks passed
@mergify mergify bot deleted the mergify/bp/jazzy/pr-165 branch May 6, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @mikaelarguedas