8000 roslaunch dependency check test looks in manifest.xml for dependency · Issue #332 · ros/ros_comm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roslaunch dependency check test looks in manifest.xml for dependency #332

Closed
shaun-edwards opened this issue Jan 5, 2014 · 2 comments
Closed

roslaunch dependency check test looks in manifest.xml for dependency #332

shaun-edwards opened this issue Jan 5, 2014 · 2 comments
Assignees
@dirk-thomas
Labels
bug

Comments

@shaun-edwards
Copy link

The roslaunch_add_file_check macro complains about missing dependency in manifest.xml file. It's not clear if the script is looking for the manifest.xml file (in which case it would fail under catkin) or if the dependency is truly missing (which I don't think it is).

The following steps reproduce the problem:

  1. Clone the repo:
    git clone https://github.com/shaun-edwards/industrial_core.git
    git checkout rosi_issue_11_launch_test
  2. Make/run the tests:
    catkin_make run_tests_industrial_robot_simulator

Resulting output:

-- run_tests.py: execute commands
  /usr/bin/cmake -E make_directory /home/ros/ros/release/build/test_results/industrial_robot_simulator
  /opt/ros/hydro/share/roslaunch/cmake/../scripts/roslaunch-check -o /home/ros/ros/release/build/test_results/industrial_robot_simulator/roslaunch-check_launch.xml /home/ros/ros/release/src/industrial_core/industrial_robot_simulator/launch 
checking *.launch in directory /home/ros/ros/release/src/industrial_core/industrial_robot_simulator/launch
checking /home/ros/ros/release/src/industrial_core/industrial_robot_simulator/launch/robot_interface_simulator.launch
...writing test results to /home/ros/ros/release/build/test_results/industrial_robot_simulator/roslaunch-check_launch.xml
FAILURE:
[/home/ros/ros/release/src/industrial_core/industrial_robot_simulator/launch/robot_interface_simulator.launch]:
    Missing manifest dependencies: industrial_robot_simulator/manifest.xml: industrial_robot_client
wrote test file to [/home/ros/ros/release/build/test_results/industrial_robot_simulator/roslaunch-check_launch.xml]
-- run_tests.py: verify result "/home/ros/ros/release/build/test_results/industrial_robot_simulator/roslaunch-check_launch.xml"

The test was added to CMakeLists.txt:

<snip>
find_package(roslaunch)
roslaunch_add_file_check(launch)
<snip>

The package xml has the following depends:

<build_depend>industrial_robot_client</build_depend>
<run_depend>industrial_robot_client</run_depend>

This appears to be a bug in the roslaunch test macros.
@shaun-edwards shaun-edwards mentioned this issue Jan 5, 2014
Closed
5 tasks
@gavanderhoorn
Copy link
Contributor

Seems adding a dummy manifest.xml to industrial_robot_simulator containing just:

<package>
  <depend package="industrial_robot_client" />
</package>

makes the test pass.

@ghost ghost assigned dirk-thomas Jan 6, 2014
@dirk-thomas
Copy link
Member

The problem is that the dependency (industrial_robot_client) is not released and rospkg is unable to resolve that since it is only barely aware of wet stuff. #333 explicitly falls back to catkin_pkg to resolve the actual run dependencies.

dirk-thomas added a commit that referenced this issue Jan 7, 2014
@dirk-thomas
Merge pull request #333 from ros/roslaunch_check_unreleased_depends
ef1910f 
fix roslaunch-check for unreleased wet dependencies (fix #332)
@shaun-edwards shaun-edwards mentioned this issue Jan 7, 2014
Merged
rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this issue Jun 19, 2017
@dirk-thomas
fix roslaunch-check for unreleased wet dependencies (fix ros#332)
ce9d05b
rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this issue Jun 19, 2017
@dirk-thomas
Merge pull request ros#333 from ros/roslaunch_check_unreleased_depends
64a96c2 
fix roslaunch-check for unreleased wet dependencies (fix ros#332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirk-thomas dirk-thomas

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dirk-thomas @shaun-edwards @gavanderhoorn
0