8000 roslaunch dependency check test looks in manifest.xml for dependency · Issue #332 · ros/ros_comm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.
This repository was archived by the owner on May 31, 2025. It is now read-only.
roslaunch dependency check test looks in manifest.xml for dependency #332
Closed
@shaun-edwards

Description

@shaun-edwards

The roslaunch_add_file_check macro complains about missing dependency in manifest.xml file. It's not clear if the script is looking for the manifest.xml file (in which case it would fail under catkin) or if the dependency is truly missing (which I don't think it is).

The following steps reproduce the problem:

  1. Clone the repo:
    git clone https://github.com/shaun-edwards/industrial_core.git
    git checkout rosi_issue_11_launch_test
  2. Make/run the tests:
    catkin_make run_tests_industrial_robot_simulator

Resulting output:

-- run_tests.py: execute commands
  /usr/bin/cmake -E make_directory /home/ros/ros/release/build/test_results/industrial_robot_simulator
  /opt/ros/hydro/share/roslaunch/cmake/../scripts/roslaunch-check -o /home/ros/ros/release/build/test_results/industrial_robot_simulator/roslaunch-check_launch.xml /home/ros/ros/release/src/industrial_core/industrial_robot_simulator/launch 
checking *.launch in directory /home/ros/ros/release/src/industrial_core/industrial_robot_simulator/launch
checking /home/ros/ros/release/src/industrial_core/industrial_robot_simulator/launch/robot_interface_simulator.launch
...writing test results to /home/ros/ros/release/build/test_results/industrial_robot_simulator/roslaunch-check_launch.xml
FAILURE:
[/home/ros/ros/release/src/industrial_core/industrial_robot_simulator/launch/robot_interface_simulator.launch]:
    Missing manifest dependencies: industrial_robot_simulator/manifest.xml: industrial_robot_client
wrote test file to [/home/ros/ros/release/build/test_results/industrial_robot_simulator/roslaunch-check_launch.xml]
-- run_tests.py: verify result "/home/ros/ros/release/build/test_results/industrial_robot_simulator/roslaunch-check_launch.xml"

The test was added to CMakeLists.txt:

<snip>
find_package(roslaunch)
roslaunch_add_file_check(launch)
<snip>

The package xml has the following depends:

<build_depend>industrial_robot_client</build_depend>
<run_depend>industrial_robot_client</run_depend>

This appears to be a bug in the roslaunch test macros.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0