8000 XmlRpcClient does not build with MSVC · Issue #2087 · ros/ros_comm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

XmlRpcClient does not build with MSVC #2087

Closed
joelwilliamsonoctopuz opened this issue Oct 30, 2020 · 3 comments
Closed

XmlRpcClient does not build with MSVC #2087

joelwilliamsonoctopuz opened this issue Oct 30, 2020 · 3 comments
Assignees
@mjcarroll

Comments

@joelwilliamsonoctopuz
Copy link

#2065 introduced the INT_MAX symbol in XmlRpcClient.cpp. This symbol is GCC specific (and is not defined by MSVC). It should use INT_MAX or std::numeric_limits<size_t>::max().

I can make a PR to fix this, do I need to fill out a CLA or anything of that sort?
@mjcarroll
Copy link
Member

I can make a PR to fix this, do I need to fill out a CLA or anything of that sort?

No CLA is necessary for ROS1, a fix would be appreciated.

@mjcarroll mjcarroll self-assigned this Nov 20, 2020
@Tobias-Fischer
Copy link
Contributor

44fa5cf#diff-b5a1494faaaf332a384a92ae8a218bcd75e17335bfe904b56bcdc6977e96118a also does not compile with MSVC ..

@sloretz sloretz closed this as completed May 31, 2025
@sloretz
Copy link
Contributor
sloretz commented May 31, 2025

ROS 1 is end-of-life (EOL) as of today, May 31st 2025. I am archiving this repository because:

  • it only supports ROS 1
  • it isn't needed anymore in ROS 2

If you still rely on ROS 1, read this page to learn about your options.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjcarroll mjcarroll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mjcarroll @sloretz @Tobias-Fischer @joelwilliamsonoctopuz
0