8000 fix shebang line for python3 by mikaelarguedas · Pull Request #466 · ros/geometry2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shebang line for python3 #466

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix shebang line for python3 #466

merged 1 commit into from
Jun 2, 2020

Conversation

mikaelarguedas
Copy link
Member

Similar to ros-visualization/rqt_graph#43

Without this change the script cannot be rosrun on Noetic/Focal and results in:
/usr/bin/env: ‘python’: No such file or directory

Python scripts need to be installed using catkin_install_python for the shebang line to be rewritten to point to python3. More details at https://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs

tf2_tools is not a python package so I just updated the shebang line to be point to python3

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

@mikaelarguedas
fix shebang line for python3
0fb47c0 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas requested a review from tfoote as a code owner June 1, 2020 17:43
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-noetic-ninjemys-release/14262/22

tfoote
tfoote approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member
@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixup. I guess this is missed in testing in a virtualenv where python is supplanted.

@tfoote
Copy link
Member
tfoote commented Jun 1, 2020

@ros-pull-request-builder retest this please.

@tfoote tfoote merged commit bd06488 into noetic-devel Jun 2, 2020
@tfoote tfoote deleted the fix_python3_shebang branch June 2, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelarguedas @ros-discourse @tfoote
0