This repository was archived by the owner on May 31, 2025. It is now read-only.
destruction_guard_test: fix build failure with new boost 1.67 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posix_time::milliseconds should not take a float in input
cd /<<PKGBUILDDIR>>/build/test && /usr/bin/c++ -DROSCONSOLE_BACKEND_LOG4CXX -DROS_PACKAGE_NAME=\"actionlib\" -I/<<PKGBUILDDIR>>/build/devel/include -I/<<PKGBUILDDIR>>/include -I/usr/share/xmlrpcpp/cmake/../../../include/xmlrpcpp -g -O3 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -o CMakeFiles/actionlib-destruction_guard_test.dir/destruction_guard_test.cpp.o -c /<<PKGBUILDDIR>>/test/destruction_guard_test.cpp
/<<PKGBUILDDIR>>/test/destruction_guard_test.cpp: In member function ‘virtual void TestRunner_threaded_test_Test::TestBody()’:
/<<PKGBUILDDIR>>/test/destruction_guard_test.cpp:89:68: error: no matching function for call to ‘boost::date_time::subsecond_duration<boost::posix_time::time_duration, 1000>::subsecond_duration(float)’
cond_.timed_wait(lock, boost::posix_time::milliseconds(100.0f));
^
|
Thanks! looks like it was missed when we converted the other usages of boost::posix_time::milliseconds. Follow up of #105 |
mikaelarguedas
approved these changes
Jul 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion
2F98
is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posix_time::milliseconds should not take a float in input
cd /<>/build/test && /usr/bin/c++ -DROSCONSOLE_BACKEND_LOG4CXX -DROS_PACKAGE_NAME="actionlib" -I/<>/build/devel/include -I/<>/include -I/usr/share/xmlrpcpp/cmake/../../../include/xmlrpcpp -g -O3 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -o CMakeFiles/actionlib-destruction_guard_test.dir/destruction_guard_test.cpp.o -c /<>/test/destruction_guard_test.cpp
/<>/test/destruction_guard_test.cpp: In member function ‘virtual void TestRunner_threaded_test_Test::TestBody()’:
/<>/test/destruction_guard_test.cpp:89:68: error: no matching function for call to ‘boost::date_time::subsecond_duration<boost::posix_time::time_duration, 1000>::subsecond_duration(float)’
cond_.timed_wait(lock, boost::posix_time::milliseconds(100.0f));
^