[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of xml namespaces imported via xacro:include in a macro #287

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

rhaschke
Copy link
Contributor
@rhaschke rhaschke commented Oct 2, 2021

Namespace declarations are lifted to the parent of the include node.
In case of a macro instantiation, this is a dummy node whose contents are kept but which is removed itself.
Hence, before removing the dummy node, we need to lift any namespace definitions.

@rhaschke rhaschke changed the title Fix handling of xml namespaces imported via xacro:include in a macro (#287) Fix handling of xml namespaces imported via xacro:include in a macro Oct 2, 2021
…os#287)

Namespace declarations are lifted to the parent of the include node.
In case of a macro instantiation, this is a dummy node whose contents are kept
but which is removed itself.
Hence, before removing the dummy node, we need to lift any namespace definitions.
@rhaschke rhaschke force-pushed the fix-namespace-lifting branch from 44bc134 to 857e5bf Compare October 2, 2021 17:53
@rhaschke rhaschke merged commit ce201d7 into ros:melodic-devel Oct 2, 2021
@rhaschke rhaschke deleted the fix-namespace-lifting branch October 2, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant