-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated xacro.py #239
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Deprecated in 2015: #71 |
@ros-pull-request-builder retest this please |
+1 to clear it out, that was deprecated 5 years ago into Jade. |
investigating test failures; I don't see them on the dev job (or locally :() Edit: it was caused by me removing |
dfb8a5f
to
ba59621
Compare
Thanks. I missed that during cleaning up... |
release PR: ros/rosdistro#24993 |
Added to migration guide: http://wiki.ros.org/noetic/Migration#Use_xacro_instead_of_xacro.py |
@sloretz, thanks. |
Fixes #237
xacro.py is currently installed without using
catkin_install_python()
, so it's shebang isn't properly rewritten. This PR solves the problem by deleting the file; which should be OK since it's deprecated.I tried installing the file using
catkin_install_python()
before deciding to delete the file, but ran into issues. The filexacro.py
has some logic to avoid recursively importing itself; but that logic doesn't seem to work in thedevel
space if the file is installed withcatkin_install_python()
. I wasn't able to figure out a way around it.