[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated xacro.py #239

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

sloretz
Copy link
Contributor
@sloretz sloretz commented May 20, 2020

Fixes #237

xacro.py is currently installed without using catkin_install_python(), so it's shebang isn't properly rewritten. This PR solves the problem by deleting the file; which should be OK since it's deprecated.

I tried installing the file using catkin_install_python() before deciding to delete the file, but ran into issues. The file xacro.py has some logic to avoid recursively importing itself; but that logic doesn't seem to work in the devel space if the file is installed with catkin_install_python(). I wasn't able to figure out a way around it.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Contributor Author
sloretz commented May 20, 2020

Deprecated in 2015: #71

@sloretz
Copy link
Contributor Author
sloretz commented May 20, 2020

@ros-pull-request-builder retest this please

@tfoote
Copy link
Member
tfoote commented May 20, 2020

+1 to clear it out, that was deprecated 5 years ago into Jade.

@sloretz
Copy link
Contributor Author
sloretz commented May 20, 2020

investigating test failures; I don't see them on the dev job (or locally :()

Edit: it was caused by me removing scripts argument from setup.py, same as ros-visualization/rqt_graph#44

@sloretz sloretz force-pushed the sloretz/remove_xacro_py branch from dfb8a5f to ba59621 Compare May 20, 2020 23:27
@sloretz
Copy link
Contributor Author
sloretz commented May 21, 2020

@codebot @rhaschke what do you think? If it looks ok; may I merge and release to Noetic?

@rhaschke rhaschke merged commit 3d71ffc into noetic-devel May 21, 2020
@rhaschke
Copy link
Contributor

Thanks. I missed that during cleaning up...
Could you please add a note in the Noetic migration guide how to adapt roslaunch files?

@rhaschke rhaschke deleted the sloretz/remove_xacro_py branch May 21, 2020 09:42
@rhaschke
Copy link
Contributor

release PR: ros/rosdistro#24993

@rhaschke rhaschke mentioned this pull request May 21, 2020
@sloretz
Copy link
Contributor Author
sloretz commented May 21, 2020

Could you please add a note in the Noetic migration guide how to adapt roslaunch files?

Added to migration guide: http://wiki.ros.org/noetic/Migration#Use_xacro_instead_of_xacro.py

@rhaschke
Copy link
Contributor

@sloretz, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python: No such file or directory
3 participants