[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard rospy function to filter ros remapping arguments from rqt plugin arguments #76

Closed

Conversation

jbohren
Copy link
Member
@jbohren jbohren commented Apr 2, 2013

Currently, not all ROS remapping arguments are removed from python's sys.argv when passed to the rqt_gui plugins. This uses the builtin rospy.myargs() function to filter out these arguments.

@jbohren
Copy link
Member Author
jbohren commented Apr 12, 2013

Is there a reason why remapping arguments aren't allowed in rqt guis?

@dirk-thomas
Copy link
Contributor

Since there is only one ROS node the remapping arguments would apply for all plugins which is likely not desired.

@jbohren
Copy link
Member Author
jbohren commented Apr 12, 2013

Then if I want to remap the topics coming out of rqt_bag, or any other rqt_gui-based gui, that processing needs to happen in those modules, or is remapping just not going to be supported?

@dirk-thomas
Copy link
Contributor

ROS only supports remapping per-node. RQT runs a single ROS node (per language) (if not run in multi-process mode) and therefore can not provide per-plugin remapping.

@dirk-thomas
Copy link
Contributor

Passing the remapping arguments from the command line when invoking RQT can indeed be passed to the single ROS node (one per language) which is currently not done.

@jbohren
Copy link
Member Author
jbohren commented Apr 13, 2013

So the only feature you'd accept is a GUI remapping interface for rqt_bag?

@dirk-thomas
Copy link
Contributor

I am sorry but I can't follow you. I don't understand why it is about what I would accept nor what a GUI remapping interface for rqt_bag might be.

Please describe what your exact use case is - may be that help to clarify what feature you expect. We could also continue that discussion on the rqt mailing list ros-sig-rqt@googlegroups.com since it looks like it requires more information and discussion.

@DorianScholz
Copy link
Member

Any news on this issue?
Is there any chance to merge this back into Groovy?

@dirk-thomas
Copy link
Contributor

The hydro-devel branch only existed for a short amount of time without me knowing. Since there is not difference I have removed it some time ago. I will apply this patch to the groovy-devel branch. Thx for the comment.

dirk-thomas added a commit that referenced this pull request May 26, 2013
@130s
Copy link
Member
130s commented May 27, 2013

@dirk-thomas
For hydro-devel branch, I'm sure I created it when I was initial-releaseing into hydro, and removing the branch shouldn't matter at all.
Also, related to this, I added branching policy to wiki.

@DorianScholz
Copy link
Member

Thanks for applying the patch again. Any chance you could trigger a build to get this into the packages?

@dirk-thomas
Copy link
Contributor

A lot of core packages will be released in the next days. In this run I will also release rqt and its dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants