-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard rospy function to filter ros remapping arguments from rqt plugin arguments #76
Use standard rospy function to filter ros remapping arguments from rqt plugin arguments #76
Conversation
…rqt plugin arguments
Is there a reason why remapping arguments aren't allowed in rqt guis? |
Since there is only one ROS node the remapping arguments would apply for all plugins which is likely not desired. |
Then if I want to remap the topics coming out of rqt_bag, or any other rqt_gui-based gui, that processing needs to happen in those modules, or is remapping just not going to be supported? |
ROS only supports remapping per-node. RQT runs a single ROS node (per language) (if not run in multi-process mode) and therefore can not provide per-plugin remapping. |
Passing the remapping arguments from the command line when invoking RQT can indeed be passed to the single ROS node (one per language) which is currently not done. |
So the only feature you'd accept is a GUI remapping interface for rqt_bag? |
I am sorry but I can't follow you. I don't understand why it is about what I would accept nor what a GUI remapping interface for rqt_bag might be. Please describe what your exact use case is - may be that help to clarify what feature you expect. We could also continue that discussion on the rqt mailing list ros-sig-rqt@googlegroups.com since it looks like it requires more information and discussion. |
Any news on this issue? |
The hydro-devel branch only existed for a short amount of time without me knowing. Since there is not difference I have removed it some time ago. I will apply this patch to the groovy-devel branch. Thx for the comment. |
@dirk-thomas |
Thanks for applying the patch again. Any chance you could trigger a build to get this into the packages? |
A lot of core packages will be released in the next days. In this run I will also release rqt and its dependencies. |
Currently, not all ROS remapping arguments are removed from python's sys.argv when passed to the rqt_gui plugins. This uses the builtin
rospy.myargs()
function to filter out these arguments.