8000 Feature request: Add random U.S. Social Security Numbers · Issue #121 · ropensci/charlatan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature request: Add random U.S. Social Security Numbers #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aalexandersson opened this issue Feb 15, 2022 · 3 comments · Fixed by #129
Closed

Feature request: Add random U.S. Social Security Numbers #121

aalexandersson opened this issue Feb 15, 2022 · 3 comments · Fixed by #129
Labels
feature good-first-issue

Comments

@aalexandersson
Copy link

Would be nice to have charlatan generate random U.S. Social Security Numbers (SSN).
Was commented "can do" but then removed from the v0.3 milestone in issue 61 in 2018.

Can possibly reuse some of the SSN code from Python library faker at
https://github.com/joke2k/faker/blob/master/faker/providers/ssn/en_US/__init__.py
@sckott
Copy link
Collaborator
sckott commented Feb 18, 2022

if you are willing, making the change yourself via a pull request would be the fastest way to get this done. what do you think?

@aalexandersson
Copy link
Author

Scott, thank you very much for the reply. Much appreciated! I might be interested but I have not done a PR before. Is the package is still being developed? For everyone who are willing but not necessarily able, are these the required steps?

  1. Fork it.
  2. Clone it to your local system.
  3. Make a new branch.
  4. Make your changes.
  5. Push it back to your repo.
  6. Click the Compare & pull request button.
  7. Click Create pull request to open a new pull request.

Source: https://opensource.com/article/19/7/create-pull-request-github
Are those instructions from 2019 still correct? Or can you recommend better instructions?

@sckott
Copy link
Collaborator
sckott commented Mar 14, 2022

Is the package is still being developed?

Sort of. I've moved on to another job so I don't get paid to work on this anymore. I try to keep it running, but ideally a new maintainer with more time will take over.

are these the required steps?

Yes. those are the steps!

@RMHogervorst RMHogervorst mentioned this issue Sep 26, 2022
Closed
@nfultz nfultz mentioned this issue Oct 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good-first-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generates SSN numbers nfultz/charlatan
3 participants
@sckott @RMHogervorst @aalexandersson
0