8000 Please return self instead of Qnil when the image did not meet the qualifier. · Issue #130 · rmagick-temp/rmagick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Please return self instead of Qnil when the image did not meet the qualifier. #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fukuchi opened this issue Mar 26, 2015 · 1 comment
Open

Please return self instead of Qnil when the image did not meet the qualifier. #130

fukuchi opened this issue Mar 26, 2015 · 1 comment

Comments

@fukuchi
Copy link
fukuchi commented Mar 26, 2015

Hi,

When I rotate an image with a qualifier and it was not qualified, rotate method returns Qnil. However, this breaks method chaining like this:

image.rotate(90, '>'),resize_to_fit(96,128) # causes 'undefined method'
image.minify.rotate(90, '>') # if nil returned, all previous operations are lost

Why does it simply return self instead of nil? As far as I guess, no one needs to know whether it was rotated or not.
@bf4
Copy link
bf4 commented May 26, 2015

Please close this issue as the repo has moved rmagick/rmagick#120 At this time we do not have access to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bf4 @fukuchi
0