8000 Implementing `rkt app list`, `rkt app status`, `rkt app exec` · Issue #3135 · rkt/rkt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

Implementing rkt app list, rkt app status, rkt app exec #3135

Closed
yifan-gu opened this issue Aug 29, 2016 · 1 comment
Closed

Implementing rkt app list, rkt app status, rkt app exec #3135

yifan-gu opened this issue Aug 29, 2016 · 1 comment
Assignees
@yifan-gu
Labels
area/cri required-by/rktnetes
Milestone
v1+

Comments

@yifan-gu
Copy link
Contributor
yifan-gu commented Aug 29, 2016 •
edited
Loading

This follows #2932

These three doesn't require much changes to existing rkt. So I put them altogether.

rkt app list

rkt app list will provide minimum information on what are running in the pod, and their states.
More detailed information can be retrieved by rkt app status in further.

The example output for rkt app list would be:

$ rkt app list <pod-uuid>
NAME STATE
appName1 running
appName2 exited
...

rkt app status

$ rkt app status <pod-uuid> --app=<app-name> 
name=appName1
state=running
created_at=1472507426
started_at=1472507430
finished_at=0
exit_code=0
imageID=imageIDFoo
mounts=/path/to/host/foo:/path/to/container/bar
annotations=key1=value1,key2=value2

The rkt app list and rkt app status could be implemented by aliasing today's rkt list and 'rkt status`. Which means it does not have to implement new stage1 entrypoints.

Some discussion points:

  • Should we return as key value pairs like I listed above, or should we return a json structured file? Or both, by providing an optional --format=json flag.

rkt app exec

$ rkt app exec <pod-uuid> --app=<app-name>  <command> <command-arguments>

This is equivalent to

$ rkt enter --app=<app-name> <pod-uuid> <command> <command-arguments>

cc @euank @tmrts @s-urbaniak
@yifan-gu yifan-gu added this to the v1.15.0 milestone Aug 29, 2016
@yifan-gu yifan-gu changed the title Implementing rkt app list and rkt app status Implementing rkt app list, rkt app status, rkt app exec Aug 30, 2016
@yifan-gu yifan-gu self-assigned this Aug 30, 2016
@tmrts
Copy link
Contributor
tmrts commented Aug 31, 2016

SGTM with the exception that rkt app status requires a JSON-like entrypoint mentioned in the docs

@s-urbaniak s-urbaniak modified the milestones: vCRI, v1.15.0, v1.17.0 Sep 15, 2016
@s-urbaniak s-urbaniak modified the milestones: v1+, v1.17.0 Oct 12, 2016
@s-urbaniak s-urbaniak mentioned this issue Nov 7, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yifan-gu yifan-gu

Labels
area/cri required-by/rktnetes
Projects
None yet
Milestone
v1+
Development

No branches or pull requests
3 participants
@s-urbaniak @yifan-gu @tmrts
0