8000 Filter crashing redirects when dispatch variable not included · Issue #7 · rgielen/struts1filter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Filter crashing redirects when dis 8000 patch variable not included #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
icyneko opened this issue Mar 28, 2019 · 2 comments
Open

Filter crashing redirects when dispatch variable not included #7

icyneko opened this issue Mar 28, 2019 · 2 comments

Comments

@icyneko
Copy link
icyneko commented Mar 28, 2019

Hi there.

My application has a function that displays search results on the same screen, but hidden behind a #results tag that we use to trigger the display of the search results or not, along with normal struts navigation. When applying your filter, when we navigate to a blah.do operation, we're fine. However, when we do blah.do#results, it causes a cascading core dump:

javax.servlet.ServletException: Request[/runSearch] does not contain handler parameter named 'dispatch'. This may be caused by whitespace in the label text.

I'm suspecting it has to do with the regex, which I used the suggested one:

(..|^|.|[('|"))(c|C)lass(.|('|")]|[).*

Do you have any suggestions on how to address this issue?
@icyneko
Copy link
Author
icyneko commented Mar 28, 2019

Upon further review, our jsp does two things:

  1. it sets the results flag
  2. it then sets the dispatcher.

I put a system out on the ParamFilteredRequest method and the system out on the body variable does show the dispatch value, However, it does not retain it when it passes through your filter. So I'm wondering if the blacklist is stripping it.

@philippebn
Copy link

equivalent filter

https://gist.github.com/philippebn/999f5dd22d0d703d7534f46d6d68519e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philippebn @icyneko
0