8000 Getting some jsonschema specific URL returns an error · Issue #2731 · rero/rero-ils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Getting some jsonschema specific URL returns an error #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jma opened this issue Feb 28, 2022 · 2 comments · Fixed by #3653
Closed

Getting some jsonschema specific URL returns an error #2731

jma opened this issue Feb 28, 2022 · 2 comments · Fixed by #3653
Assignees
@rerowep
Labels
bug Breaks something but is not blocking effort: minor Solved quickly

Comments

@jma
Copy link
Contributor
jma commented Feb 28, 2022 •
edited by PascalRepond
Loading

Bug description:

Calling the specific schema.properties.$schema.default of a schema returns an error.

Examples:

For some reason, https://bib.test.rero.ch/schemas/items/item-v0.0.1.json works.

Version:

v1.10.0

Sentry
https://sentryils.rero.ch:8443/share/issue/9f08fa0b4c8240b7a857eb0a073f3dc9/
@jma jma added the bug Breaks something but is not blocking label Feb 28, 2022
@PascalRepond PascalRepond added the developers From a developer point of view. label Mar 1, 2022
@PascalRepond PascalRepond added dev: monitoring Alert system like Sentry or Zabbix. effort: minor Solved quickly p-Medium Medium priority (to be solved within 1-2 years) labels Mar 18, 2022
@vgranata vgranata self-assigned this Mar 28, 2022
@vgranata

This comment was marked as outdated.

Sign in to view
@PascalRepond PascalRepond changed the title Getting the holding jsonschema returns an error. Getting some jsonschema specific URL returns an error May 4, 2022
@PascalRepond PascalRepond removed developers From a developer point of view. p-Medium Medium priority (to be solved within 1-2 years) dev: monitoring Alert system like Sentry or Zabbix. labels Mar 30, 2023
@PascalRepond PascalRepond moved this to Project Backlog in RERO ILS issues Mar 30, 2023
@jma
Copy link
Contributor Author
jma commented Aug 22, 2023

This can be reproduced in local by serving the application with FLASK_DEBUG=0. This occurs only with schema containing $ref which seems returns a JSONRef object which cannot be serialized. In DEBUG mode a dict is returned. One solution can be to do a deep copy in a code specified to JSONSCHEMAS_RESOLVER_CLS but it is a workaround. This problem can comes from a specific version of jsonref.

@PascalRepond PascalRepond moved this from Product Backlog to Ready to test in RERO ILS issues Apr 25, 2024
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Apr 25, 2024
@PascalRepond PascalRepond mentioned this issue Apr 25, 2024
Merged
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues May 6, 2024
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking effort: minor Solved quickly
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

schema: fix schema in production rerowep/rero-ils
4 participants
@jma @rerowep @vgranata @PascalRepond
0