8000 Themed variants of images · Issue #31 · readysettech/docs-old · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Themed variants of images #31
Open
@KianNH

Description

@KianNH

Thought I'd make an issue before opening a pull request myself to get your thoughts on a few things.

The images currently embed very nicely on the light theme, almost as if they have a transparent background.

image

When we swap to dark mode, you'll get the white background that's always been there.

image

The Material theme for MkDocs supports showing different variants of an image based on the state of the theme toggle here but that'll naturally involve a bit more maintenance burden as far as doing it retroactively and doing it in the future.

Is this something that the team is open to? Happy to contribute myself but don't want to jump into it if it's not something that you'd like to do.

As a side note, I think some of the images could benefit from zoom functionality - such as the one on the memory efficiency page.

image

I'm not too sure if it supports animated images though so that's probably worth a different issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0