From f673a8503e74f12dc20327070308e6b5345abb25 Mon Sep 17 00:00:00 2001 From: Matthew Palombi Date: Tue, 18 Oct 2022 10:37:34 -0400 Subject: [PATCH 1/3] feat: add all option to create-project Signed-off-by: Matthew Palombi --- commands/create-project.js | 15 ++++++++++++++- index.js | 2 +- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/commands/create-project.js b/commands/create-project.js index 8c5ceb0..25bb9ef 100644 --- a/commands/create-project.js +++ b/commands/create-project.js @@ -9,13 +9,26 @@ const methodMap = { api: createProjectApi, admin: createProjectAdmin, storefront: createProjectStorefront, - demo: createProjectDemo + demo: createProjectDemo, + all: createProjectAll }; const extraDependencyMap = { storefront: ["yarn"] }; +/** + * @summary creates api, admin, and storefront projects at same time in separate directories. + * @param {String} projectName - The name of the project to create + * @param {Object} options - Project options + */ +export async function createProjectAll(projectName, options) { + createProjectApi(projectName + "Api", options); + createProjectAdmin(projectName + "Admin", options); + createProjectStorefront(projectName + "Storefront", options); + return true; +} + /** * @summary create one of the project types * @param {String} projectType - One of the project types diff --git a/index.js b/index.js index f55fbd1..a75ec21 100755 --- a/index.js +++ b/index.js @@ -24,7 +24,7 @@ program program .command("create-project") .description("Create a new Open Commerce project of one of several types") - .addArgument(new commander.Argument("", "which project type to create").choices(["api", "storefront", "admin", "demo"])) + .addArgument(new commander.Argument("", "which project type to create").choices(["api", "storefront", "admin", "all", "demo"])) .argument("", "what to name the project") // .option("--populate") .option("--skip-meteor-install", "Skip Meteor install when creating admin project") From decb8bee4b01400d52a07afa5ad0263a81684915 Mon Sep 17 00:00:00 2001 From: Brent Hoover Date: Tue, 25 Oct 2022 17:33:41 +0800 Subject: [PATCH 2/3] Revert "fix: correct the update message. Closes #62" Signed-off-by: Brent Hoover --- utils/checkForNewVersion.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/utils/checkForNewVersion.js b/utils/checkForNewVersion.js index 34d2857..bb4f84f 100644 --- a/utils/checkForNewVersion.js +++ b/utils/checkForNewVersion.js @@ -12,7 +12,5 @@ const pkg = require("../package.json"); */ export default async function checkForNewVersion() { const notifier = updateNotifier({ pkg }); - const updateCommand = "npm i -g reaction-cli"; - const updateMessage = `Run ${updateCommand} to update.`; - notifier.notify({ message: updateMessage }); + notifier.notify(); } From 32558f9950e42d529a77696fbd3f3f8389901599 Mon Sep 17 00:00:00 2001 From: Brent Hoover Date: Tue, 25 Oct 2022 09:41:55 +0000 Subject: [PATCH 3/3] fix: fix lint errors from another PR Signed-off-by: Brent Hoover --- commands/create-project.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/commands/create-project.js b/commands/create-project.js index 25bb9ef..e1a4cc0 100644 --- a/commands/create-project.js +++ b/commands/create-project.js @@ -21,11 +21,12 @@ const extraDependencyMap = { * @summary creates api, admin, and storefront projects at same time in separate directories. * @param {String} projectName - The name of the project to create * @param {Object} options - Project options + * @returns {Boolean} true if success */ export async function createProjectAll(projectName, options) { - createProjectApi(projectName + "Api", options); - createProjectAdmin(projectName + "Admin", options); - createProjectStorefront(projectName + "Storefront", options); + createProjectApi(`${projectName}Api`, options); + createProjectAdmin(`${projectName}Admin`, options); + createProjectStorefront(`${projectName}Storefront`, options); return true; }