generic attribute types
#7941
Replies: 1 comment 1 reply
-
|
Sounds good 👍 Something like this one? |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
ooh lol. exactly. 😎 |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
currently we are using
setAttributeandgetAttribtueonNodein a lot of places.this api is not typed though.
I wonder whether we can e.g. utilize generics or create a small PHPStan extension, to make the PHPStan analysis in rector-src repo aware of the types involved when working with attributes. IMO depending on the used attribute we most of the time know which type is involved...
wdyt?
Beta Was this translation helpful? Give feedback.
All reactions