rector conflicts with nikic/php-parser #6958

staabm · 2022-01-21T11:37:32Z

staabm
Jan 21, 2022

I have a project with the following composer.json

{
    "name": "staabm/zf-select-strip",
    "license": "MIT",
    "require": {
        "php": "^8.0",
        "nikic/php-parser": "^4.13",
        "rector/rector": "^0.12",
        "phpstan/phpstan": "^1.2",
        "zendframework/zendframework1": "^1.12"
    },
    "require-dev": {
        "ext-pdo": "*",
        "friendsofphp/php-cs-fixer": "3.4.0",
        "phpstan/phpstan-php-parser": "^1.1",
        "phpstan/phpstan-phpunit": "^1.0",
        "phpstan/phpstan-strict-rules": "^1.1",
        "phpunit/phpunit": "^9",
        "symplify/phpstan-extensions": "^10.0"
    },

    "autoload": {
        "psr-4": {
            "staabm\\ZfSelectStrip\\": "src/"
        }
    },
    "autoload-dev": {
        "psr-4": {
            "staabm\\ZfSelectStrip\\Tests\\": "tests/"
        },
        "classmap": [
            "tests/classes/"
        ]
    },
    "scripts": {
        "csfix": [
            "php-cs-fixer fix"
        ],
        "phpstan-dba-baseline": [
            "phpunit",
            "phpstan analyse -c phpstan.neon.dist"
        ],
        "phpstan": [
            "phpstan analyse -c phpstan.neon.dist"
        ],
        "phpunit": [
            "phpunit"
        ]
    },
    "config": {
        "optimize-autoloader": true,
        "sort-packages": true,
        "allow-plugins": {
            "cweagans/composer-patches": true,
            "rector/extension-installer": true
        }
    }
}

as soon as I use

        "nikic/php-parser": "^4.13",
        "rector/rector": "^0.12",

in tandem , I get errors when running phpunit

PHP Fatal error:  Cannot declare interface PhpParser\Node, because the name is already in use in C:\dvl\Workspace\zf-select-strip\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\Node.php on line 6

it seems the problem is, that rector itself includes nikic/php-parser again.

how is the correct way to declare the dependency to rector in a project in which I want to develop new phpstan extensions in tandem with new rectors?

staabm · 2022-01-21T11:39:32Z

staabm
Jan 21, 2022
Author

said differently: I am using some dev tools which depend on nikic/php-parser:

$ composer why nikic/php-parser
phpunit/php-code-coverage  9.2.10   requires  nikic/php-parser (^4.13.0)
sebastian/complexity       2.0.2    requires  nikic/php-parser (^4.7)
sebastian/lines-of-code    1.0.3    requires  nikic/php-parser (^4.6)
symplify/astral            10.0.14  requires  nikic/php-parser (^4.13.2)

and even if my project does not declare a direct dependency to nikic/php-parser the one embedded in rector stays in conflict with the one in the project (which gets installed because transitive dependency)

using rector 0.12.13

the rector embedded php-parser inside vendor/rector/rector/vendor/

the global one in the projects vendor/

0 replies

TomasVotruba · 2022-01-21T11:42:28Z

TomasVotruba
Jan 21, 2022
Maintainer

Thanks for reporting the issue. We're using Rector and packages that use php-parser in many projects and it runs propperly.
This looks like autoloading conflict. Could you reproduce in repository on Github with failing action? I'll investigate, where is gets stuck.

6 replies

staabm Jan 21, 2022
Author

as a workaround on my local machine I commented the require-once calls of preload.php

samsonasik Jan 21, 2022
Maintainer

@staabm could you verify if this PR solve the issue ?

staabm Jan 21, 2022
Author

maybe rector should declare that it provides nikic/php-parser?

https://getcomposer.org/doc/04-schema.md#provide

samsonasik Jan 21, 2022
Maintainer

The phpunit redeclare issue usually solved by run to directory directly, eg:

vendor/bin/phpunit tests

TomasVotruba Jan 21, 2022
Maintainer

@samsonasik Agreed, I came to a similar solution.

TomasVotruba · 2022-01-21T13:35:08Z

TomasVotruba
Jan 21, 2022
Maintainer

Here are few notes: https://github.com/staabm/zf-select-strip/pull/8/files

0 replies

Lewiscowles1986 · 2022-04-01T23:32:58Z

Lewiscowles1986
Apr 1, 2022

~~Question if I might.~~ So is the https://github.com/rectorphp/rector/tree/main/src/PhpParser actually nikic/php-parser? If So why on earth is it not in the composer.json? 🤯

Answered myself (see comment)

2 replies

Lewiscowles1986 Apr 1, 2022

Hmm. Seems like this is a difference between rectorphp/rector and rectorphp/rector-src ... see rector-src composer.json

Question withdrawn, but this seems very strange.

10000

TomasVotruba Apr 2, 2022
Maintainer

We're using:

development repository (on PHP 8.1) - just for contributors, https://github.com/rectorphp/rector-src
and release repository (on PHP 7.2 and scoped) - for yourself, end-used https://github.com/rectorphp/rector

Check post on Rector blog that explains it with examples: https://getrector.org/blog/how-to-bump-minimal-version-without-leaving-anyone-behind

Uh oh!

rector conflicts with nikic/php-parser #6958

Uh oh!

staabm Jan 21, 2022

Replies: 4 comments · 8 replies

Uh oh!

Uh oh!

staabm Jan 21, 2022 Author

Uh oh!

TomasVotruba Jan 21, 2022 Maintainer

Uh oh!

Uh oh!

staabm Jan 21, 2022 Author

Uh oh!

samsonasik Jan 21, 2022 Maintainer

Uh oh!

staabm Jan 21, 2022 Author

Uh oh!

samsonasik Jan 21, 2022 Maintainer

Uh oh!

TomasVotruba Jan 21, 2022 Maintainer

Uh oh!

TomasVotruba Jan 21, 2022 Maintainer

Uh oh!

Uh oh!

Lewiscowles1986 Apr 1, 2022

Uh oh!

Lewiscowles1986 Apr 1, 2022

Uh oh!

TomasVotruba Apr 2, 2022 Maintainer

staabm
Jan 21, 2022

Replies: 4 comments 8 replies

staabm
Jan 21, 2022
Author

TomasVotruba
Jan 21, 2022
Maintainer

staabm Jan 21, 2022
Author

samsonasik Jan 21, 2022
Maintainer

staabm Jan 21, 2022
Author

samsonasik Jan 21, 2022
Maintainer

TomasVotruba Jan 21, 2022
Maintainer

TomasVotruba
Jan 21, 2022
Maintainer

Lewiscowles1986
Apr 1, 2022

TomasVotruba Apr 2, 2022
Maintainer