8000 Propagate .options changes when SwiftUI View is updated · Issue #697 · rechsteiner/Parchment · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Propagate .options changes when SwiftUI View is updated #697
Closed
@nfgrilo

Description

@nfgrilo
  • SwiftUI only
  • git branch: 4.0

Currently, when the View holding the PageView has changes and need refresh, PageView modifiers changes are not propagated to UIKit (but SwiftUI contents inside Page are 👍🏼).

My use case is that I support custom themes on my app, and everything is correctly updated except for the menu items.

I have attached three patches (4.0 branch):

  • one to demonstrate the issue/use case (changes are applied to DefaultView on ExampleSwiftUI target)
  • one to allow the propagation of .options via PagingControllerRepresentableView.updateUIViewController()
  • one to respect the .indicatorStyle() modifier (after propagating options)

0001-Added-changes-to-DefaultView-to-exemplify.patch
0002-Propagate-.options-modifiers-on-View-updates.patch
0003-Fixed-.indicatorStyle-not-being-respected.patch

I would be very grateful if you could give a try and have a look!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0