Open
Description
I know this may not directly merit any functionality provided by RDFIO but if time permits maybe consider the following re-factoring to ease maintenance in future by using some common assumptions about PHP.
- One class per file
RDFIO/classes/RDFIO_ARC2StoreWrapper.php
Lines 200 to 201 in 4338de2
- Remove dependency on
MWExceptionand use standard exceptions likeRuntimeExceptionor classes thereof - Move classes (except for scripts) to
/srcand related sub-directories- When moving classes consider using the
RDFIOnamespace instead of naming each class withRDFIO... - Match class names against PSR-4 such as
/src/Parserto correspond toRDFIO\Parser\ARC2ToWikiConverter.php
- When moving classes consider using the
- For public functions use the
publicprefix to make visibility more clearer - When moving a class try to create a simple unit test to at least cover the constructor (can be extended at any time)
- For "pure" unit tests avoid
MediaWikiTestCaseand instead use the standardPHPUnit_Framework_TestCase - Documentation such as
RDFIOCallGraph.pdfmay find a more dedicated location (e.g./docs)
Metadata
Metadata
Assignees
Labels
No labels